Red Hat Bugzilla – Bug 847436
Review Request: spherical-cow-backgrounds - Spherical Cow desktop backgrounds
Last modified: 2012-08-15 11:05:26 EDT
Spec URL: http://mso.fedorapeople.org/packages/SPECS/spherical-cow-backgrounds.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/spherical-cow-backgrounds-17.90.2-1.fc17.src.rpm
Description: This package contains desktop backgrounds for the Spherical Cow theme.
Fedora Account System Username: mso
Note: it's practically same as most previous releases, and it's directly based on beefy-miracle-backgrounds package. The package division:
-single: common files for single-screen backgrounds,
-gnome: files intended for gnome DE,
-xfce: files intended for XFCE,
-kde: files intended for KDE,
main package: pulls everything.
The URL isn't functional yet, but I hope to create the wiki page soon.
Update images appeared, so I updated the rpm as well:
Group: not needed anymore, optional tag, http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
License: ok, CC-BY-SA
URL: not yet created, standard destination for Fedora artwork, please create asap
Sources: ok, md5sum d62c522b46ddf16fe191d8060da449eb
Macros used consistently: ok
%clean section is not needed anymore, http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
rm -rf $RPM_BUILD_ROOT is not needed anymore in %install section, http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
Otherwise it's a simple package, based on beefy-miracle-backgrounds package. You can cleanup the SPEC file according to the current package guidelines but it's not a blocker and the package has to be finalized today.
Thanks for the review, Jaroslav.
New Package SCM Request
Package Name: spherical-cow-backgrounds
Short Description: Spherical Cow desktop backgrounds
Git done (by process-git-requests).