Bug 848112

Summary: libvirt-lxc should not hard code /selinux or /sys/fs/selinux at buildtime. It should check at runtime.
Product: [Fedora] Fedora Reporter: Daniel Walsh <dwalsh>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: berrange, clalancette, crobinso, dougsland, itamar, jforbes, jyang, laine, libvirt-maint, veillard, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-01 08:57:44 EDT Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Daniel Walsh 2012-08-14 12:08:52 EDT
Currently libvirt-lxc is checking for /selinux or /sys/fs/selinux at build time, but when it is built in koji, it is being build on a RHEL6 box which has /selinux.  When we install this on a F18 box, /selinux does not exist and /sys/fs/selinux should be used.

The library should be checking for the existance of /sys/fs/selinux and falling back to /selinux.
Comment 1 Daniel Berrange 2012-08-14 12:12:39 EDT
Libvirt attempts to figure this out at configure time, but fails with Fedora for the above mentioned reasons. We can however force the correct choice using --with-selinux-mount. The RPM spec file can be modified to pass the correct value per-distro release.
Comment 2 Cole Robinson 2013-04-01 08:57:44 EDT
The F18 spec appears to do the right thing already, so closing.