Bug 848112 – libvirt-lxc should not hard code /selinux or /sys/fs/selinux at buildtime. It should check at runtime.

Bug 848112 - libvirt-lxc should not hard code /selinux or /sys/fs/selinux at buildtime. It should check at runtime.

Summary:	libvirt-lxc should not hard code /selinux or /sys/fs/selinux at buildtime. I...

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	libvirt (Show other bugs)
Sub Component:
Version:	18
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	---
Target Release:	---
Assigned To:	Libvirt Maintainers
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2012-08-14 12:08 EDT by Daniel Walsh
Modified:	2013-04-01 08:57 EDT (History)
CC List:	11 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2013-04-01 08:57:44 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Daniel Walsh 2012-08-14 12:08:52 EDT

Currently libvirt-lxc is checking for /selinux or /sys/fs/selinux at build time, but when it is built in koji, it is being build on a RHEL6 box which has /selinux.  When we install this on a F18 box, /selinux does not exist and /sys/fs/selinux should be used.

The library should be checking for the existance of /sys/fs/selinux and falling back to /selinux.

Comment 1 Daniel Berrange 2012-08-14 12:12:39 EDT

Libvirt attempts to figure this out at configure time, but fails with Fedora for the above mentioned reasons. We can however force the correct choice using --with-selinux-mount. The RPM spec file can be modified to pass the correct value per-distro release.

Comment 2 Cole Robinson 2013-04-01 08:57:44 EDT

The F18 spec appears to do the right thing already, so closing.

Note You need to log in before you can comment on or make changes to this bug.