Bug 848112 - libvirt-lxc should not hard code /selinux or /sys/fs/selinux at buildtime. It should check at runtime.
Summary: libvirt-lxc should not hard code /selinux or /sys/fs/selinux at buildtime. I...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-14 16:08 UTC by Daniel Walsh
Modified: 2013-04-01 12:57 UTC (History)
11 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-04-01 12:57:44 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Daniel Walsh 2012-08-14 16:08:52 UTC 
Currently libvirt-lxc is checking for /selinux or /sys/fs/selinux at build time, but when it is built in koji, it is being build on a RHEL6 box which has /selinux.  When we install this on a F18 box, /selinux does not exist and /sys/fs/selinux should be used.

The library should be checking for the existance of /sys/fs/selinux and falling back to /selinux.
Comment 1 Daniel Berrangé 2012-08-14 16:12:39 UTC 
Libvirt attempts to figure this out at configure time, but fails with Fedora for the above mentioned reasons. We can however force the correct choice using --with-selinux-mount. The RPM spec file can be modified to pass the correct value per-distro release.
Comment 2 Cole Robinson 2013-04-01 12:57:44 UTC 
The F18 spec appears to do the right thing already, so closing.
Note You need to log in before you can comment on or make changes to this bug.