Bug 850582

Summary: RFE allow macros in dagman log files to assist templating
Product: Red Hat Enterprise MRG Reporter: Timothy St. Clair <tstclair>
Component: condorAssignee: grid-maint-list <grid-maint-list>
Status: CLOSED WONTFIX QA Contact: MRG Quality Engineering <mrgqe-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: DevelopmentCC: esammons, ltoscano, matt, mkudlej, rrati, tstclair
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Rebase: Enhancements Only
Doc Text:
Important: if this rebase also contains *bug fixes* (or contains only bug fixes), select the correct option from the Doc Type drop-down list. Rebase package(s) to version: condor-7.8 series Highlights and notable enhancements: Allows macros in dagman log files to assist templating.
Story Points: ---
Clone Of:
: 877227 (view as bug list) Environment:
Last Closed: 2016-05-26 15:12:34 EDT Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 877227    

Description Timothy St. Clair 2012-08-21 17:23:20 EDT
Mentioned on condor-users:

Universe   = standard
requirements = (Arch == "X86_64")&&  (OpSys == "LINUX")
Executable = /path/to/binary
transfer_executable = TRUE
should_transfer_files = IF_NEEDED
when_to_transfer_output = ON_EXIT
Arguments  = $(param)
Output     = $(id).stdout
Error      = $(id).stderr
Log        = $(id).condor_log
Queue
NODE_STATUS_FILE dag_status
JOBSTATE_LOG     dag_log
JOB   RT000-rt0.01 itersave.condor_job
VARS  RT000-rt0.01 param="000 GT"
VARS  RT000-rt0.01 id="RT000-rt0.01"
RETRY RT000-rt0.01 3
JOB   RT001-rt0.01 itersave.condor_job
VARS  RT001-rt0.01 param="001 GT"
VARS  RT001-rt0.01 id="RT001-rt0.01"
RETRY RT001-rt0.01 3
(and more)

MultiLogFiles: macros ('$(...') not allowed in log file name
($(id).condor_log) in DAG node submit files
DAGMan strictly protects against possibly changing UserLog files because of the presence of macros. This covers $(Cluster) and $(Process). However, it also covers against VARS ID=ABC, as in this example, a macro that is not variable and instead allows for template submit files.

Proposal is to more narrowly disallow macros (nix Process/Cluster/anything-that-evals-at-submit-time-with-Process-or-Cluster-or-Time-etc) or give users who know what they are doing an escape hatch, a way to say "yes, i'm using macros properly, trust me"
Comment 8 Anne-Louise Tangring 2016-05-26 15:12:34 EDT
MRG-G is in maintenance only and only customer escalations will be addressed from this point forward. This issue can be re-opened if a customer escalation associated with this issue occurs.