Bug 851198

Summary: ovirt-engine-backend [TEXT]: please remove the word "Action" from attach/detach CanDoAction
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: ovirt-engineAssignee: Asaf Shakarchi <asaf>
Status: CLOSED CURRENTRELEASE QA Contact: Dafna Ron <dron>
Severity: low Docs Contact:
Priority: medium    
Version: unspecifiedCC: abaron, amureini, dyasny, ecohen, hateya, iheim, lpeer, Rhev-m-bugs, sgrinber, vvyazmin, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.1.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: SI21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
log none

Description Dafna Ron 2012-08-23 13:32:44 UTC
Created attachment 606563 [details]
log

Description of problem:

detach: 

Cannot Dettach Action from Virtual Machine Disk. The VM status is illegal.

attach:

Cannot attach Action to Virtual Machine Disk. Disk is Illegal. Illegal disks can only be deleted.

Version-Release number of selected component (if applicable):

si15

How reproducible:

100%

Steps to Reproduce:
1. attach: try to attach a disk which is in illegal state or two bootable disks to the same vm
2. detach: try to detach a disk while running the vm at the same time.
3.
  
Actual results:

both attach and detach have the word "Action" in the CanDoAction

Expected results:

we should remove the work "Action" from CanDoAction

Additional info:

Comment 1 Ayal Baron 2012-08-23 21:34:52 UTC
(In reply to comment #0)
> Created attachment 606563 [details]
> log
> 
> Description of problem:
> 
> detach: 
> 
> Cannot Dettach Action from Virtual Machine Disk. The VM status is illegal.

Need to fix:
    @DefaultStringValue("$action attach Action to")
    String VAR__ACTION__ATTACH_ACTION_TO();

    @DefaultStringValue("$action Dettach Action from")
    String VAR__ACTION__DETACH_ACTION_TO();

Also note that "Dettach" should be written: "detach"

Comment 2 Einav Cohen 2012-08-25 07:59:09 UTC
Note that the .properties file(s) should probably be changed, rather than the default values in the java file(s) with the Constants interface (we would like to get rid of the defaults within the code eventually).

Comment 3 Asaf Shakarchi 2012-09-09 15:11:43 UTC
this is actually wrong in user portal as well,
Patch submitted: http://gerrit.ovirt.org/#/c/7880/
Fixed in all relevant locations.

Comment 4 Allon Mureinik 2012-10-15 08:45:56 UTC
merged Iae923c89c71eccfc695cbb8e5dd417808c04d54b

Comment 5 Dafna Ron 2012-10-21 13:45:49 UTC
verified on si21.1 
tested on two bootable disks since illegal are filtered by UI

Comment 6 Vered Volansky 2012-11-06 08:40:58 UTC
*** Bug 833900 has been marked as a duplicate of this bug. ***