Bug 851295

Summary: splitsep doesn't correctly handle variables with escaped spaces
Product: [Fedora] Fedora Reporter: Brian Lane <bcl>
Component: dracutAssignee: dracut-maint
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 18CC: awilliam, dracut-maint, jonathan, kparal, robatino, wwoods
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: AcceptedBlocker
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-09-07 23:19:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 752654, 848641    
Attachments:
Description Flags
add quotes none

Description Brian Lane 2012-08-23 17:36:45 UTC 
splitsep doesn't correctly handle variables with escaped spaces in it. eg.

splitsep : 'anaconda-disk:LABEL=Fedora\x2018\x20x86_64' f diskdev diskpath

results in LABEL=Fedorax2018x20x86_64

Anaconda uses this to parse the inst.stage2 argument (among other things).
Comment 1 Brian Lane 2012-08-23 17:37:59 UTC 
Created attachment 606665 [details]
add quotes
Comment 2 Will Woods 2012-08-23 21:02:20 UTC 
Sent a patch upstream:

http://marc.info/?l=initramfs&m=134575536504285&w=2
Comment 3 Adam Williamson 2012-08-27 16:34:33 UTC 
Discussed at 2012-08-27 QA meeting, functioning as a blocker review meeting. Accepted as a blocker per criterion "The installer must boot (if appropriate) and run on all primary architectures, with all system firmware types that are common on those architectures, from default live image, DVD, and boot.iso install media when written to an optical disc and when written to a USB stick with at least one of the officially supported methods", on the understanding this causes problems with USB boot.
Comment 4 Adam Williamson 2012-08-29 17:58:54 UTC 
Harald, can we please have a build of dracut with this fix ASAP? It's blocking quite a lot of other work on the Alpha. thanks!
Comment 5 Fedora Update System 2012-08-31 05:57:17 UTC 
dracut-023-21.git20120823.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/FEDORA-2012-13041/dracut-023-21.git20120823.fc18
Comment 6 Kamil Páral 2012-09-03 08:53:55 UTC 
Brian, is this fixed in F18 Alpha TC5? Or how can I check?
Comment 7 Adam Williamson 2012-09-05 18:12:10 UTC 
<bcl> if it has inst.stage2=hd:LABEL= and label has spaces and it boots when you dd it, it worked.
Comment 8 Adam Williamson 2012-09-06 21:16:06 UTC 
With TC6, a dd'ed netinst ISO gives a LABEL= that looks right, and it boots. Setting VERIFIED (update is not yet pushed).
Comment 9 Fedora Update System 2012-09-07 23:19:25 UTC 
dracut-023-21.git20120823.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.