Bug 851889 (libmate)
| Summary: | Review Request: libmate -- MATE Desktop base libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Mashal <dan.mashal> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-09-03 00:47:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 840149 | ||
|
Description
Dan Mashal
2012-08-26 23:26:08 UTC
1. MUST: simplify %files devel includes to just
%{_includedir}/libmate-2.0/
so the parent and all subdirs are owned too.
2. MUST move
%{_datadir}/gtk-doc/html/libmate/
to -devel, these items are usually developer/api documentation (unless you have reason to believe otherwise).
3. SHOULD remove
%pre
/sbin/ldconfig
(not needed here, just %post, %postun)
4. SHOULD consider simplifying mate-conf-related scriptlets. I believe it's possible to list them all at once, instead of one per line, but I'll leave that to your discretion.
Fixed. Left mate conf scriptlets alone for now. Knew about that, did it on purpose for now. Spec URL: http://vicodan.fedorapeople.org/matespec/libmate.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/libmate-1.4.0-2.fc17.src.rpm Description: MATE Desktop base libraries naming: ok
license: ok
sources: ok
12cbd0c29abf817501ce8c5233f5aa4e libmate-1.4.0.tar.xz
macros: ok
scriptlets: ok
SHOULD: occurs to me the schema files under
%{_sysconfdir}/mateconf/schemas
probably ought not be marked as %config , in spite of rpmlint
looks good, APPROVED.
New Package SCM Request ======================= Package Name: libmate Short Description: MATE Desktop base libraries Owners: vicodan rdieter Branches: f16 f17 f18 Git done (by process-git-requests). libmateweather-1.4.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libmateweather-1.4.0-4.fc17 libmateweather-1.4.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libmateweather-1.4.0-4.fc18 Sorry about that. Wrong bug number. ;) libmate-1.4.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libmate-1.4.0-2.fc17 libmate-1.4.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libmate-1.4.0-2.fc18 libmate-1.4.0-2.fc18 has been pushed to the Fedora 18 testing repository. libmate-1.4.0-2.fc17 has been pushed to the Fedora 17 stable repository. libmate-1.4.0-2.fc18 has been pushed to the Fedora 18 stable repository. |