Bug 852241
Summary: | Watchdog never starts if power configuration is not present | ||
---|---|---|---|
Product: | [Retired] Beaker | Reporter: | Raymond Mancy <rmancy> |
Component: | lab controller | Assignee: | Nick Coghlan <ncoghlan> |
Status: | CLOSED NOTABUG | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 0.9 | CC: | bpeck, dcallagh, ebaak, kbaker, mishin, rmancy |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | Provisioning | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-01-29 01:57:16 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Raymond Mancy
2012-08-28 01:11:14 UTC
I think the recipe should start (that is, enter Running state and have a watchdog kill time defined) once the machine reaches Anaconda %pre. But you're right, until then the recipe will remain Waiting with no watchdog kill time. This was my oversight in commit 56c72d19 for bug 835373. AFAICT the %pre will not cause it to enter a Running state as it explicitly tests whether the task is already running before it extends it (and does not if it isn't). In fact perhaps this is the most logical place to have the start being recorded, although it looks we've gone out of our way not to do that, and I'm sure there is a good reason why. Bulk reassignment of issues as Bill has moved to another team. When provisioning a recipe we only issue a reboot if the system supports power control. We should just add an else: branch on there which starts the recipe immediately if there's no power control. This is now happening thanks to the install_start() method that is called from %pre |