Bug 853350
| Summary: | [RFE] CLI to comment on jobs | ||
|---|---|---|---|
| Product: | [Retired] Beaker | Reporter: | Monson Shao <jshao> |
| Component: | command line | Assignee: | Blake McIvor <bmcivor> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Anwesha Chatterjee <achatter> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 0.9 | CC: | achatter, bmcivor, bpeck, ccui, dcallagh, ebaak, rjoost, tools-bugs |
| Target Milestone: | 25.0 | Keywords: | FutureFeature, Patch |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | CommandLineEnhancement | ||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-03-19 04:19:02 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Comment 1
Nick Coghlan
2012-10-17 04:40:01 UTC
Now that recipe sets have multiple (immutable) comments, rather than a single comment that can be edited, we probably want a slightly different CLI for it. Adding a comment is not really modifying the job. And for completeness we would want a way to comment on recipes and recipe tasks as well. How about: bkr job-comment RS:123 --message="Dan says hi" So it would accept a taskspec, similar to the other commands, which lets you comment on either recipe set, task, or result. (In reply to Dan Callaghan from comment #4) > Now that recipe sets have multiple (immutable) comments, rather than a > single comment that can be edited, we probably want a slightly different CLI > for it. Adding a comment is not really modifying the job. And for > completeness we would want a way to comment on recipes and recipe tasks as > well. > > How about: > > bkr job-comment RS:123 --message="Dan says hi" > > So it would accept a taskspec, similar to the other commands, which lets you > comment on either recipe set, task, or result. Understood so far, except for commenting on a result. Is that to be added? as there currently no taskpec argument for that. In some other bkr commands we accept TR:123 for identifying task-results, don't we? it appears so now I had a look, I was going off the options provided in the man page for bkr You could also fix the man page to mention TR:123. Unfortunately this missed the feature freeze for 24.0. Strictly speaking it shouldn't go into a bug fix release either, since the new client functionality will rely on server-side API changes... Tested the feature by installing: * beaker-client-25.0-0.git.90.109f06397.el6eng.noarch.rpm * beaker-common-25.0-0.git.90.109f06397.el6eng.noarch.rpm and posting a comment to a task as follows: `bkr job-comment T:1 --message="Hello is it me you're looking for"` Verified that the comment appeared in the task summary section for T:1 in the recipe page Beaker 25.0 has been released. Release notes are available upstream: https://beaker-project.org/docs/whats-new/release-25.html |