Bug 853350 - [RFE] CLI to comment on jobs
Summary: [RFE] CLI to comment on jobs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: command line
Version: 0.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 25.0
Assignee: Blake McIvor
QA Contact: Anwesha Chatterjee
URL:
Whiteboard: CommandLineEnhancement
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-31 08:05 UTC by Monson Shao
Modified: 2018-03-19 04:19 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-19 04:19:02 UTC
Embargoed:


Attachments (Terms of Use)

Comment 1 Nick Coghlan 2012-10-17 04:40:01 UTC
Bulk reassignment of issues as Bill has moved to another team.

Comment 4 Dan Callaghan 2016-05-18 21:37:08 UTC
Now that recipe sets have multiple (immutable) comments, rather than a single comment that can be edited, we probably want a slightly different CLI for it. Adding a comment is not really modifying the job. And for completeness we would want a way to comment on recipes and recipe tasks as well.

How about:

bkr job-comment RS:123 --message="Dan says hi"

So it would accept a taskspec, similar to the other commands, which lets you comment on either recipe set, task, or result.

Comment 5 Blake McIvor 2016-05-31 05:02:59 UTC
(In reply to Dan Callaghan from comment #4)
> Now that recipe sets have multiple (immutable) comments, rather than a
> single comment that can be edited, we probably want a slightly different CLI
> for it. Adding a comment is not really modifying the job. And for
> completeness we would want a way to comment on recipes and recipe tasks as
> well.
> 
> How about:
> 
> bkr job-comment RS:123 --message="Dan says hi"
> 
> So it would accept a taskspec, similar to the other commands, which lets you
> comment on either recipe set, task, or result.

Understood so far, except for commenting on a result. Is that to be added? as there currently no taskpec argument for that.

Comment 6 Dan Callaghan 2016-05-31 13:15:11 UTC
In some other bkr commands we accept TR:123 for identifying task-results, don't we?

Comment 7 Blake McIvor 2016-05-31 22:25:37 UTC
it appears so now I had a look, I was going off the options provided in the man page for bkr

Comment 8 Dan Callaghan 2016-06-01 14:13:59 UTC
You could also fix the man page to mention TR:123.

Comment 9 Blake McIvor 2016-06-23 00:40:32 UTC
https://gerrit.beaker-project.org/#/c/5003/

Comment 10 Dan Callaghan 2017-01-12 01:07:10 UTC
Unfortunately this missed the feature freeze for 24.0. Strictly speaking it shouldn't go into a bug fix release either, since the new client functionality will rely on server-side API changes...

Comment 12 Anwesha Chatterjee 2018-01-04 03:50:23 UTC
Tested the feature by installing:

* beaker-client-25.0-0.git.90.109f06397.el6eng.noarch.rpm
* beaker-common-25.0-0.git.90.109f06397.el6eng.noarch.rpm

and posting a comment to a task as follows:

`bkr job-comment T:1 --message="Hello is it me you're looking for"`

Verified that the comment appeared in the task summary section for T:1 in the recipe page

Comment 13 Roman Joost 2018-03-19 04:19:02 UTC
Beaker 25.0 has been released.

Release notes are available upstream: https://beaker-project.org/docs/whats-new/release-25.html


Note You need to log in before you can comment on or make changes to this bug.