Bug 853689
| Summary: | Review Request: libmateui - Libraries for MATE Desktop UI | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Mashal <dan.mashal> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-09-25 16:39:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 840149 | ||
|
Description
Dan Mashal
2012-09-02 07:08:09 UTC
Initial review:
naming: ok
sources: ok
c48f2213a0511c60c8811af503c60337 libmateui-1.4.0.tar.xz
scriptlets: not ok
1. MUST add ldconfig scriptlets to main pkg
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
2. -devel pkg dep on main MUST be arch'd use
Requires: %{name}%{?_isa} = %{version}-%{release}
3. SHOULD move
%{_datadir}/gtk-doc/html/libmateui/
to -devel
license: not ok
4. MUST set license tag
License: LGPLv2+
and include
%doc COPYING.LIB
in main pkg
5. MUST remove unneeded
BuildRequires: gtk+-devel
Fixed: Spec URL: http://vicodan.fedorapeople.org/matespec/libmateui.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/libmateui-1.4.0-2.fc17.src.rpm Description: Libraries for MATE Desktop UI excellent, new srpm looks good, APPROVED. New Package SCM Request ======================= Package Name: libmateui Short Description: Libraries for MATE Desktop ui Owners: vicodan rdieter Branches: f16 f17 f18 Git done (by process-git-requests). libmateui-1.4.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libmateui-1.4.0-2.fc17 libmateui-1.4.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libmateui-1.4.0-2.fc18 libmateui-1.4.0-2.fc17 has been pushed to the Fedora 17 testing repository. libmateui-1.4.0-2.fc18 has been pushed to the Fedora 18 stable repository. |