Bug 853692 (mate-settings-daemon)

All these files belong in the main package and not in -devel

%{_libdir}/mate-settings-daemon-1.4.0/liba11y-keyboard.so
%{_libdir}/mate-settings-daemon-1.4.0/libclipboard.so
%{_libdir}/mate-settings-daemon-1.4.0/libfont.so
%{_libdir}/mate-settings-daemon-1.4.0/libhousekeeping.so
%{_libdir}/mate-settings-daemon-1.4.0/libkeybindings.so
%{_libdir}/mate-settings-daemon-1.4.0/libkeyboard.so
%{_libdir}/mate-settings-daemon-1.4.0/libmedia-keys.so
%{_libdir}/mate-settings-daemon-1.4.0/libmouse.so
%{_libdir}/mate-settings-daemon-1.4.0/libsmartcard.so
%{_libdir}/mate-settings-daemon-1.4.0/libsound.so
%{_libdir}/mate-settings-daemon-1.4.0/libtyping-break.so
%{_libdir}/mate-settings-daemon-1.4.0/libxrandr.so
%{_libdir}/mate-settings-daemon-1.4.0/libxrdb.so
%{_libdir}/mate-settings-daemon-1.4.0/libxsettings.so

thanks leigh, but those are shared libaries. how to proceed?

(In reply to comment #2)
> thanks leigh, but those are shared libaries. how to proceed?

Move them to the main package

# rpm -ql gnome-settings-daemon |grep /usr/lib64/gnome-settings-daemon-3.0
/usr/lib64/gnome-settings-daemon-3.0/a11y-keyboard.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/a11y-settings.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/background.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/clipboard.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/color.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/cursor.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/housekeeping.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/keyboard.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/liba11y-keyboard.so
/usr/lib64/gnome-settings-daemon-3.0/liba11y-settings.so
/usr/lib64/gnome-settings-daemon-3.0/libbackground.so
/usr/lib64/gnome-settings-daemon-3.0/libclipboard.so
/usr/lib64/gnome-settings-daemon-3.0/libcolor.so
/usr/lib64/gnome-settings-daemon-3.0/libcursor.so
/usr/lib64/gnome-settings-daemon-3.0/libgsd.so
/usr/lib64/gnome-settings-daemon-3.0/libgsdwacom.so
/usr/lib64/gnome-settings-daemon-3.0/libhousekeeping.so
/usr/lib64/gnome-settings-daemon-3.0/libkeyboard.so
/usr/lib64/gnome-settings-daemon-3.0/libmedia-keys.so
/usr/lib64/gnome-settings-daemon-3.0/libmouse.so
/usr/lib64/gnome-settings-daemon-3.0/liborientation.so
/usr/lib64/gnome-settings-daemon-3.0/libpower.so
/usr/lib64/gnome-settings-daemon-3.0/libprint-notifications.so
/usr/lib64/gnome-settings-daemon-3.0/libsmartcard.so
/usr/lib64/gnome-settings-daemon-3.0/libsound.so
/usr/lib64/gnome-settings-daemon-3.0/libupdates.so
/usr/lib64/gnome-settings-daemon-3.0/libxrandr.so
/usr/lib64/gnome-settings-daemon-3.0/libxsettings.so
/usr/lib64/gnome-settings-daemon-3.0/media-keys.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/mouse.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/orientation.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/power.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/print-notifications.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/smartcard.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/sound.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/updates.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/wacom.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/xrandr.gnome-settings-plugin
/usr/lib64/gnome-settings-daemon-3.0/xsettings.gnome-settings-plugin



You also need to add mate-conf scriptlets

Fixed. Please check it.

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-settings-daemon.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-settings-daemon-1.4.0-2.fc17.src.rpm
Description: MATE Desktop settings daemon

I can review this (later) today

1. MUST remove
BuildRequires: gcc-c++
it's included in
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

naming: ok

licensing: ok

2.  sources: not ok
Source0:        http://vicodan.fedorapeople.org/mate-settings-daemon-1.4.0.tar.gz
MUST use verifiable upstream sources or provide justification why you're not doing so.

scriptlets: ok (mostly, except for...)

3.  MUST remove
ldconfig from %pre,%post,%postun, this package has no shared libraries (just plugins), so it's not needed.

4.  MUST own dir
%{_libdir}/mate-settings-daemon-1.4.0/
I'd recommend just listing ^^ , instead of all items under that separately.


scriptlets

Fixed build with mate-desktop-1.4.1-11, so you can use upstream sources now.

OK. 

Fixed:

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-settings-daemon.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-settings-daemon-1.4.0-3.fc17.src.rpm
Description: MATE Desktop settings daemon

sources: ok
$ md5sum *.xz
5d7608bf8b80f4847e6b146379568b83  mate-settings-daemon-1.4.0.tar.xz

5. MUST remove
export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/:/usr/local/share/pkgconfig/
but I won't consider it a blocker here, but please do remove prior to doing any official builds

6. SHOULD remove
%pre
/sbin/ldconfig
this scriptlet is only required in %post and %postun

7. SHOULD add
Requires: mate-icon-theme
for /usr/share/icons/mate parent dir ownership (or can you think of some place lower in the stack to add this dependency?)

8. SHOULD remove rpath hacks
chrpath --delete %{buildroot}%{_libdir}/mate-settings-daemon-1.4.0/*.so
chrpath --delete %{buildroot}%{_libexecdir}/msd-locate-pointer
they're not needed

9. MUST own
%{_libdir}/mate-settings-daemon-1.4.0/
I'd suggest simplifying the %files list to just ^^ , and not list each item under it individually.

oh, sorry, ignore item 6.  Please do honor item 3, there are no shared libraries here, so no need for ldconfig scriplets at all.

chrpath is needed.. package was failing when i was building with out it.. ill double check in a bit.

prior to suggesting it, I tested that it built fine for me without chrpath on my box.

(In reply to comment #11)
> chrpath is needed.. package was failing when i was building with out it..
> ill double check in a bit.

The koji buildsystem doesn't require it to build.
Did you add it to fix a local build issue on your PC?

Yeah that's why I said I need to debug. I'm still sitting in bed recovering from last night's hackathon. :) LOL

>5. MUST remove
>export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/:/usr/local/share/pkgconfig/
>but I won't consider it a blocker here, but please do remove prior to doing any >official builds

Builds fail without this. Please check it.

>6. SHOULD remove
>%pre
>/sbin/ldconfig
>this scriptlet is only required in %post and %postun

Done

>7. SHOULD add
>Requires: mate-icon-theme
>for /usr/share/icons/mate parent dir ownership (or can you think of some place >lower in the stack to add this dependency?)

Done, no I can't.

>8. SHOULD remove rpath hacks
>chrpath --delete %{buildroot}%{_libdir}/mate-settings-daemon-1.4.0/*.so
>chrpath --delete %{buildroot}%{_libexecdir}/msd-locate-pointer
>they're not needed

Done but rpmlint still complains.

>9. MUST own
>%{_libdir}/mate-settings-daemon-1.4.0/
>I'd suggest simplifying the %files list to just ^^ , and not list each item >under it individually.

Done.

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-settings-daemon.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-settings-daemon-1.4.0-4.fc17.src.rpm
Description: MATE Desktop settings daemon

Thanks, looks good, APPROVED

New Package SCM Request
=======================
Package Name: mate-settings-daemon
Short Description: MATE Desktop settings daemon
Owners: rdieter vicodan
Branches: f16 f17 f18

Git done (by process-git-requests).

fyi, imported, building for rawhide now.

mate-settings-daemon-1.4.0-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mate-settings-daemon-1.4.0-5.fc18

mate-settings-daemon-1.4.0-5.fc18 has been pushed to the Fedora 18 testing repository.

not sure why bodhi isn't closing bugs but both f18 and f17 packages have been pushed to stable.