Bug 853694 (mate-control-center)

naming: ok

sources: ok
9eebb9972d1759dd001ba78fe66bde09  mate-control-center-1.4.0.tar.xz

scriptlets: ok

1. licensing: there is a mixture of LGPLv2+ and GPLv2+ sources, SHOULD simplify to just:
License: GPLv2+

2. MUST omit all stuff under %{_datadir}/mime, except for anything matching
%{_datadir}/mime/packages/*.xml
that's generated content from scriptlets (and the current stuff you list would conflict with shared-mime-info), see also item 3

3. MUST add mimeinfo-related scriptlets:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo

4.  MUST add .desktop mime-related scriptlets:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database

5. MUST drop not-needed
BuildRequires: gtk+-devel

since you'd asked in chat what item 2 was about, the .spec's %files section currently includes:
%{_datadir}/mime/XMLnamespaces
%{_datadir}/mime/aliases
%{_datadir}/mime/application/x-mate-theme-package.xml
%{_datadir}/mime/generic-icons
%{_datadir}/mime/globs
%{_datadir}/mime/globs2
%{_datadir}/mime/icons
%{_datadir}/mime/magic
%{_datadir}/mime/mime.cache
%{_datadir}/mime/packages/mate-theme-package.xml
%{_datadir}/mime/subclasses
%{_datadir}/mime/treemagic
%{_datadir}/mime/types
%{_datadir}/mime/version

whereas you only want to include
%{_datadir}/mime/packages/mate-theme-package.xml

If I drop those files I get the following:

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/share/mime/XMLnamespaces
   /usr/share/mime/aliases
   /usr/share/mime/application/x-mate-theme-package.xml
   /usr/share/mime/generic-icons
   /usr/share/mime/globs
   /usr/share/mime/globs2
   /usr/share/mime/icons
   /usr/share/mime/magic
   /usr/share/mime/mime.cache
   /usr/share/mime/subclasses
   /usr/share/mime/treemagic
   /usr/share/mime/types
   /usr/share/mime/version

Anyways please check the following updates spec/srpm:

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-2.fc17.src.rpm
Description: MATE Desktop control center

In order of preference, you'll need to:
* find a way for the buildsys not to create those files (patching maybe)
* manually delete them
or 
* use %exclude on those files.

%exclude ftw

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-3.fc17.src.rpm
Description: MATE Desktop control center

I've fixed all of the build issues, per our chat, and removed about me (pretty useless).

Please check it:

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-4.fc17.src.rpm
Description: MATE Desktop control center

Successful koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=4544916

(In reply to comment #8)
> I've fixed all of the build issues, per our chat, and removed about me
> (pretty useless).
> 
> Please check it:
> 
> Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
> SRPM URL:
> http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-4.
> fc17.src.rpm
> Description: MATE Desktop control center
> 
> Successful koji build:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=4544916

Please remove --libexecdir=/usr/libexec from


%configure --disable-static --disable-schemas-install --enable-aboutme --disable-scrollkeeper --libexecdir=/usr/libexec

The %configure macro already defines it plus you used a hard path instead of a macro ( correct way  --libexecdir=%{_libexecdir} ).

you also have a spelling mistake in

%configure --disable-static --disable-schemas-instalp --disable-scrollkeeper --libexecdir=/usr/libexec


--disable-schemas-instalp   


should be

--disable-schemas-install


Do you ever check the buildlogs?

http://kojipkgs.fedoraproject.org//work/tasks/4917/4544917/build.log

+ export LDFLAGS
+ ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --disable-static --disable-schemas-instalp --disable-scrollkeeper --libexecdir=/usr/libexec
configure: WARNING: unrecognized options: --disable-schemas-instalp
checking for a BSD-compatible install... /usr/bin/install -c


note --libexecdir=/usr/libexe is in there twice!

Thanks Leigh,

Yes, learned the hard way about looking at build logs. 

The reason why libexec is there is to avoid the conflict with gnome... what would you suggest? It does work, yes I know rpmbuild specifies a lot of this stuff but as per upstream using that flag avoids conflicts with Gnome 3. Maybe I should use export for the libexec path dir instead?

I have fixed the spelling error. Thank you for pointing this out.

Updated:

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-3.fc17.src.rpm
Description: MATE Desktop control center

(In reply to comment #11)
> Thanks Leigh,
> 
> Yes, learned the hard way about looking at build logs. 
> 
> The reason why libexec is there is to avoid the conflict with gnome... what
> would you suggest? It does work, yes I know rpmbuild specifies a lot of this
> stuff but as per upstream using that flag avoids conflicts with Gnome 3.
> Maybe I should use export for the libexec path dir instead?
> 
> I have fixed the spelling error. Thank you for pointing this out.

Well if you insist on adding the libexec bit you MUST use a macro 

eg:

--libexecdir=%{_libexecdir}

Or your package will fail the review.

(In reply to comment #12)
> Updated:
> 
> Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
> SRPM URL:
> http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-3.
> fc17.src.rpm
> Description: MATE Desktop control center

This still fails the review process.

1. use of hard path in configure command

Yes, good catch, not needed for this package. Fixing and removing the requires field.

Fixed a bunch of stuff. Removed libexecdir from configure flag. Please let me know if you find any other issues. Thanks.

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-6.fc17.src.rpm
Description: MATE Desktop control center

Ok you have claimed ownership of 

%{_datadir}/mime/XMLnamespaces
%{_datadir}/mime/aliases

you shouldn't own them. please fix 



Please remove the noconfig from all these files.

%config(noreplace) %{_sysconfdir}/mateconf/schemas/control-center.schemas
%config(noreplace) %{_sysconfdir}/mateconf/schemas/fontilus.schemas
%config(noreplace) %{_sysconfdir}/mateconf/schemas/mate-control-center.schemas
%config(noreplace) %{_sysconfdir}/xdg/autostart/mate-at-session.desktop
%config(noreplace) %{_sysconfdir}/xdg/menus/matecc.menu

They aren't user config files

(In reply to comment #17)

> Please remove the noconfig from all these files.
> 
> %config(noreplace) %{_sysconfdir}/mateconf/schemas/control-center.schemas
> %config(noreplace) %{_sysconfdir}/mateconf/schemas/fontilus.schemas
> %config(noreplace)
> %{_sysconfdir}/mateconf/schemas/mate-control-center.schemas
> %config(noreplace) %{_sysconfdir}/xdg/autostart/mate-at-session.desktop
> %config(noreplace) %{_sysconfdir}/xdg/menus/matecc.menu
> 
> They aren't user config files

I mean remove the noreplace bit

I figured as much personally. Will do.

Also remove the

Requires(post): desktop-file-utils
Requires(postun): desktop-file-utils




Note: For FC5+, this scriptlet follows the same convention as mimeinfo files and gtk-icon-cache. Namely, the spec file should not Require desktop-file-utils for this. For older releases, one should

Requires(post): desktop-file-utils
Requires(postun): desktop-file-utils

Fixed.

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-7.fc17.src.rpm
Description: MATE Desktop control center

(In reply to comment #21)
> Fixed.
> 
> Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
> SRPM URL:
> http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-7.
> fc17.src.rpm
> Description: MATE Desktop control center

You haven't fixed the ownership issue

%{_datadir}/mime/XMLnamespaces/
%{_datadir}/mime/aliases/


Please fix

building with --disable-update-mimedb option as I'd suggested in chatting will make most of that mime stuff (which you shouldn't own) go away.

Still haven't addressed item 1, though that was only a SHOULD

6. MUST  still need to delete or %exclude %{_datadir}/applications/mimeinfo.cache

7. SHOULD not run desktop-file-validate on
%{_sysconfdir}/xdg/autostart/mate-at-session.desktop
it's only required for stuff under %{_datadir}/applications/


fixup item 6, and looks like we have a winner

I actually just did that for the must.. 

was just about to update before you commented.

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-8.fc17.src.rpm
Description: MATE Desktop control center

will fix the "shoulds" before importing the packages.

mostly harmless but,
%{_datadir}/mime/packages/mate-theme-package.xml
is listed twice

and mimeinfo.cache isn't deleted or %excluded, so will likely lead to build failure (unpackaged file)



but, you can fix that later, APPROVED.

Thanks, fill fix before import as well

New Package SCM Request
=======================
Package Name: mate-control-center
Short Description: MATE Desktop control center
Owners: rdieter vicodan
Branches: f16 f17 f18

Git done (by process-git-requests).

mate-control-center-1.4.0-8.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-control-center-1.4.0-8.fc17

mate-control-center-1.4.0-8.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mate-control-center-1.4.0-8.fc18

mate-control-center-1.4.0-8.fc18 has been pushed to the Fedora 18 testing repository.