Bug 854107

Summary: imount.c: In function 'mountCommandWrapper': error: format not a string literal and no format arguments
Product: [Fedora] Fedora Reporter: Leslie Zhai <xiangzhai83>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: anaconda-maint-list, fweimer, g.kaviyarasu, jonathan, vanmeeuwen+fedora
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-12 11:43:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
pyanaconda-isys-imount.patch none

Description Leslie Zhai 2012-09-04 03:34:40 UTC
Created attachment 609532 [details]
pyanaconda-isys-imount.patch

Description of problem:
make

imount.c: In function 'mountCommandWrapper':
imount.c:198:9: error: format not a string literal and no format arguments

Version-Release number of selected component (if applicable):
anaconda-18.6.5-1

How reproducible:
vi configure.ac comment iscsi
sh autogen.sh
./configure --disable-selinux

Steps to Reproduce:
1. make
2. make: *** [all] Error 2

Actual results:
./anaconda

Expected results:
imount.c error

Additional info:

Comment 1 Chris Lumens 2012-09-11 18:59:44 UTC
I am unable to reproduce this.  anaconda builds fine in our build system.

Comment 2 Florian Weimer 2013-04-12 11:42:21 UTC
The patch is correct and avoids crashes (or worse) when logging data which happens to contain '%' characters.

Comment 3 Florian Weimer 2013-04-12 11:43:46 UTC
But this appears to have been fixed with the rewrite.