Bug 854107 - imount.c: In function 'mountCommandWrapper': error: format not a string literal and no format arguments
Summary: imount.c: In function 'mountCommandWrapper': error: format not a string liter...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: rawhide
Hardware: i686
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-09-04 03:34 UTC by Leslie Zhai
Modified: 2013-04-12 11:43 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-04-12 11:43:46 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
pyanaconda-isys-imount.patch (214 bytes, patch)
2012-09-04 03:34 UTC, Leslie Zhai
no flags Details | Diff

Description Leslie Zhai 2012-09-04 03:34:40 UTC
Created attachment 609532 [details]
pyanaconda-isys-imount.patch

Description of problem:
make

imount.c: In function 'mountCommandWrapper':
imount.c:198:9: error: format not a string literal and no format arguments

Version-Release number of selected component (if applicable):
anaconda-18.6.5-1

How reproducible:
vi configure.ac comment iscsi
sh autogen.sh
./configure --disable-selinux

Steps to Reproduce:
1. make
2. make: *** [all] Error 2

Actual results:
./anaconda

Expected results:
imount.c error

Additional info:

Comment 1 Chris Lumens 2012-09-11 18:59:44 UTC
I am unable to reproduce this.  anaconda builds fine in our build system.

Comment 2 Florian Weimer 2013-04-12 11:42:21 UTC
The patch is correct and avoids crashes (or worse) when logging data which happens to contain '%' characters.

Comment 3 Florian Weimer 2013-04-12 11:43:46 UTC
But this appears to have been fixed with the rewrite.


Note You need to log in before you can comment on or make changes to this bug.