Bug 854403

Summary: Using the sessions command when using tcm_fc results in error messages
Product: [Fedora] Fedora Reporter: Mark Rustad <mark.d.rustad>
Component: targetcliAssignee: Andy Grover <agrover>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 17CC: agrover
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-09-24 03:21:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mark Rustad 2012-09-04 22:44:39 UTC
Description of problem:
Using the sessions command when using tcm_fc results in error messages

Version-Release number of selected component (if applicable):
targetcli-2.0rc1.fb12-1.fc17
python-rtslib-2.1.fb14-1.fc17

How reproducible:
Set up an FCoE target with luns assigned to an FCoE initiator. From within targetcli, type sessions list

Steps to Reproduce:
1. Set up an FCoE target with luns assigned to an FCoE initiator
2. Discover the luns from the initiator
3. Enter "sessions list" command into targetcli
  
Actual results:
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 990, in run_interactive
    self._cli_loop()
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 813, in _cli_loop
    self.run_cmdline(cmdline)
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 934, in run_cmdline
    self._execute_command(path, command, pparams, kparams)
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 909, in _execute_command
    result = target.execute_command(command, pparams, kparams)
  File "/usr/lib/python2.7/site-packages/targetcli/ui_node.py", line 84, in execute_command
    pparams, kparams)
  File "/usr/lib/python2.7/site-packages/configshell/node.py", line 1405, in execute_command
    result = method(*pparams, **kparams)
  File "/usr/lib/python2.7/site-packages/targetcli/ui_root.py", line 202, in ui_command_sessions
    printed_sessions = list(root.sessions)
  File "/usr/lib/python2.7/site-packages/rtslib/root.py", line 134, in _list_sessions
    if na.session:
  File "/usr/lib/python2.7/site-packages/rtslib/target.py", line 883, in _get_session
    lines = fread("%s/info" % self.path).splitlines()
  File "/usr/lib/python2.7/site-packages/rtslib/utils.py", line 102, in fread
    file_fd = open(path, 'r')
IOError: [Errno 2] No such file or directory: '/sys/kernel/config/target/fc/20:00:00:1b:21:87:a6:fb/tpgt_1/acls/20:00:00:1b:21:87:ac:7b/info'


Expected results:
Well, certainly not errors. It would be nice to get some status on the initiators, but I recognize that FCoE is different from iSCSI in terms of sessions. At a minimum, there should not be these errors.

Additional info:

Comment 1 Andy Grover 2012-09-06 22:25:10 UTC
fixed, will be in fb22.

If fcoe fabric wants to report session info, it probably should support an "info" configfs file similar to iscsi's.

Comment 2 Fedora Update System 2012-09-06 22:56:36 UTC
python-rtslib-2.1.fb22-1.fc17,targetcli-2.0rc1.fb16-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-rtslib-2.1.fb22-1.fc17,targetcli-2.0rc1.fb16-1.fc17

Comment 3 Fedora Update System 2012-09-06 22:56:49 UTC
python-rtslib-2.1.fb22-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-rtslib-2.1.fb22-1.fc18

Comment 4 Fedora Update System 2012-09-07 11:37:54 UTC
Package python-rtslib-2.1.fb22-1.fc17, targetcli-2.0rc1.fb16-1.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-rtslib-2.1.fb22-1.fc17 targetcli-2.0rc1.fb16-1.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-13497/python-rtslib-2.1.fb22-1.fc17,targetcli-2.0rc1.fb16-1.fc17
then log in and leave karma (feedback).

Comment 5 Mark Rustad 2012-09-20 21:35:58 UTC
I finally got around to trying this update, but neither package seems to be found in updates-testing.

Comment 6 Fedora Update System 2012-09-24 03:21:34 UTC
python-rtslib-2.1.fb22-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2012-11-15 02:46:57 UTC
targetcli-2.0rc1.fb16-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.