Bug 85447
Summary: | ppp-watch called with wrong parameters from ifup-ppp. Peer names inoperative. Boot timeouts inoperative. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michael H. Warfield <mhw> |
Component: | initscripts | Assignee: | Bill Nottingham <notting> |
Status: | CLOSED INSUFFICIENT_DATA | QA Contact: | Brock Organ <borgan> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | barryn, denis, mitr, mitr, rvokal, triage |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | bzcl34nup | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-05-06 23:55:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 150221 |
Description
Michael H. Warfield
2003-03-02 22:51:43 UTC
I believe this is fixed in current beta initscripts. Please check there. This is just based on code examination. I don't have a spare machine to bring up a beta of RedHat 8.1 on right at the moment. Results of the code examination do NOT look promising, IAC... Still looks busted. Just busted in a different way. The parameter errors calling ppp-watch are "fixed" but now it's being called with the WRONG peername. So if DEVICE doesn't agree with the name of the config file, you call pppd with with wrong peer name of "ppp?" instead of "amber" or "green" or what ever you wanted it to be called. That also means the link name is busted AND you can't have multiple definitions for the same "ppp" device ("amber" builds an ssl tunnel, sprint does a ppp dial to ttyACM0, earthlink does a landline dial through a modem). It also means that, even though you have an "ifcfg-amber", it won't work unless you ALSO have an "ifcfg-ppp0" because ppp-watch is going to look for the "ppp0" config file. Documenation on ppp-watch is also still wrong. Usage statement from program indicates the second parameter is optional but the "if" check on argc requires at least two parameters. I think these four lines from ppp-watch.c say it all... if (argc < 2) { fprintf (stderr, "usage: ppp-watch [ifcfg-]<logical-name> [boot]\n"); exit(30); } Anything less than two parameters and you generate the usage error, but the usage message, incorrectly, states the second parameter is optional. What's unclear here? This also means that if "ifup-ppp" gets called by hand ($2 = NULL) then argc will be 1 and the command will fail. So I guess we can forget about manually starting ppp connections. Man page for ppp-watch has been "corrected" to agree with the usage statement but neither of them agree with what the code does! Still broken... *** Bug 97850 has been marked as a duplicate of this bug. *** Some of this is fixed in initscripts-7.32-1. Woops, make that 7.33-1. AFAICS this should all work fine, but I have not tested it. "these four lines" in comment #2 are actually correct, argc includes argv[0]. Based on the date this bug was created, it appears to have been reported against rawhide during the development of a Fedora release that is no longer maintained. In order to refocus our efforts as a project we are flagging all of the open bugs for releases which are no longer maintained. If this bug remains in NEEDINFO thirty (30) days from now, we will automatically close it. If you can reproduce this bug in a maintained Fedora version (7, 8, or rawhide), please change this bug to the respective version and change the status to ASSIGNED. (If you're unable to change the bug's version or status, add a comment to the bug and someone will change it for you.) Thanks for your help, and we apologize again that we haven't handled these issues to this point. The process we're following is outlined here: http://fedoraproject.org/wiki/BugZappers/F9CleanUp We will be following the process here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this doesn't happen again. This bug has been in NEEDINFO for more than 30 days since feedback was first requested. As a result we are closing it. If you can reproduce this bug in the future against a maintained Fedora version please feel free to reopen it against that version. The process we're following is outlined here: http://fedoraproject.org/wiki/BugZappers/F9CleanUp |