Bug 854691
| Summary: | Review Request: datovka - A free graphical interface for Czech Databox (Datové schránky) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> |
| Component: | Package Review | Assignee: | Jan Synacek <jsynacek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jsynacek, notting, package-review, ppisar |
| Target Milestone: | --- | Flags: | jsynacek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-20 16:27:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 854690 | ||
| Bug Blocks: | |||
|
Description
Jaroslav Škarvada
2012-09-05 14:57:38 UTC
Line 26: use %{__python}
Line {47,51,52,56}: use %{_bindir} macro
(In reply to comment #1) Thanks for the review. > Line 26: use %{__python} > Fixed. > Line {47,51,52,56}: use %{_bindir} macro > Fixed, but most of them taken from guidelines. New files: Spec URL: http://fedorapeople.org/~jskarvad/datovka/datovka.spec SRPM URL: http://fedorapeople.org/~jskarvad/datovka/datovka-2.1.2-2.fc17.src.rpm Looks good now, approving. New Package SCM Request ======================= Package Name: datovka Short Description: A free graphical interface for Czech Databox (Datové schránky) Owners: jskarvad Branches: f17 f18 InitialCC: Git done (by process-git-requests). Thanks. datovka-2.1.2-2.fc18,python-dslib-2.1.2-2.fc18,python-sudsds-1.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/datovka-2.1.2-2.fc18,python-dslib-2.1.2-2.fc18,python-sudsds-1.0-2.fc18 python-sudsds-1.0-2.fc17,python-dslib-2.1.2-2.fc17,datovka-2.1.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-sudsds-1.0-2.fc17,python-dslib-2.1.2-2.fc17,datovka-2.1.2-2.fc17 python-sudsds-1.0-2.fc17, python-dslib-2.1.2-2.fc17, datovka-2.1.2-2.fc17 has been pushed to the Fedora 17 testing repository. I strongly disagree with the review. The package is just a renamed dsgui which has not been accepted into Fedora because of bundling (bug #648973). Are you sure no libraries or fonts are bundled? (In reply to comment #10) > Are you sure no libraries or fonts are bundled? Which libraries? I can see DejaVuSans.ttf bundled, thanks for the catch, will de-bundle ASAP - we started tighter collaboration with NIC regarding datovka, so it shouldn't be problem. I can't see any libraries bundled, but I must have missed the fonts.. *** Bug 648973 has been marked as a duplicate of this bug. *** It's probably issue in the prerequisite review of python-dslib. I will follow there. datovka-2.1.2-2.fc18, python-dslib-2.1.2-2.fc18, python-sudsds-1.0-2.fc18 has been pushed to the Fedora 18 stable repository. |