Spec URL: http://fedorapeople.org/~jskarvad/datovka/datovka.spec SRPM URL: http://fedorapeople.org/~jskarvad/datovka/datovka-2.1.2-1.fc17.src.rpm Description: GUI application allowing access to Czech Databox - an electronic communication interface endorsed by the Czech government. Fedora Account System Username: jskarvad
Line 26: use %{__python} Line {47,51,52,56}: use %{_bindir} macro
(In reply to comment #1) Thanks for the review. > Line 26: use %{__python} > Fixed. > Line {47,51,52,56}: use %{_bindir} macro > Fixed, but most of them taken from guidelines. New files: Spec URL: http://fedorapeople.org/~jskarvad/datovka/datovka.spec SRPM URL: http://fedorapeople.org/~jskarvad/datovka/datovka-2.1.2-2.fc17.src.rpm
Looks good now, approving.
New Package SCM Request ======================= Package Name: datovka Short Description: A free graphical interface for Czech Databox (Datové schránky) Owners: jskarvad Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
Thanks.
datovka-2.1.2-2.fc18,python-dslib-2.1.2-2.fc18,python-sudsds-1.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/datovka-2.1.2-2.fc18,python-dslib-2.1.2-2.fc18,python-sudsds-1.0-2.fc18
python-sudsds-1.0-2.fc17,python-dslib-2.1.2-2.fc17,datovka-2.1.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-sudsds-1.0-2.fc17,python-dslib-2.1.2-2.fc17,datovka-2.1.2-2.fc17
python-sudsds-1.0-2.fc17, python-dslib-2.1.2-2.fc17, datovka-2.1.2-2.fc17 has been pushed to the Fedora 17 testing repository.
I strongly disagree with the review. The package is just a renamed dsgui which has not been accepted into Fedora because of bundling (bug #648973). Are you sure no libraries or fonts are bundled?
(In reply to comment #10) > Are you sure no libraries or fonts are bundled? Which libraries? I can see DejaVuSans.ttf bundled, thanks for the catch, will de-bundle ASAP - we started tighter collaboration with NIC regarding datovka, so it shouldn't be problem.
I can't see any libraries bundled, but I must have missed the fonts..
*** Bug 648973 has been marked as a duplicate of this bug. ***
It's probably issue in the prerequisite review of python-dslib. I will follow there.
datovka-2.1.2-2.fc18, python-dslib-2.1.2-2.fc18, python-sudsds-1.0-2.fc18 has been pushed to the Fedora 18 stable repository.