Bug 855050

Summary: Update Icon Paths in Dialog Windows - Replace Generic Icons with RHSM Icon
Product: Red Hat Enterprise Linux 5 Reporter: Matt Reid <mreid>
Component: subscription-managerAssignee: Bryan Kearney <bkearney>
Status: CLOSED ERRATA QA Contact: Entitlement Bugs <entitlement-bugs>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 5.11CC: alikins, bkearney, dgoodwin, jesusr, jsefler
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: subscription-manager-1.1.4-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-09-16 00:21:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1039651    
Attachments:
Description Flags
Generic Icon
none
Proper Icon
none
still showing generic icon in the date picker dialog decoration
none
FailedQA
none
screenshots showing subscription-manager-gui dialogs with the expected icons circled none

Description Matt Reid 2012-09-06 14:58:01 UTC
Description of problem:
We were still missing it for some dialogs, but when we switched over to using the proper PNGs instead of the SVG, we lost some of the progress we had made on eliminating the generic icon from being used in our dialogs.

Dialogs I've seen in the newer builds that are using the generic window icon:
About
License
Import Cert
System Facts
Proxy Config
System Preferences
Unregister Confirmation
Unsubscribe Confirmation
System Registration
No action needed dialog (when green and try to auto-sub)
Must manually subscribe dialog (cases where auto-sub fails)

That might not be everything, maybe there's an easy way to double-check in the code? Should be most of them at least.

If it helps to see an implemented example, the Filters and Searching (Update button) dialogs use the right icon.

Version -
1.0.17-1.git.0.279356f

Comment 1 Matt Reid 2012-09-06 15:02:50 UTC
Created attachment 610384 [details]
Generic Icon

Comment 2 Matt Reid 2012-09-06 15:03:16 UTC
Created attachment 610385 [details]
Proper Icon

Comment 3 Matt Reid 2012-10-01 19:05:42 UTC
The Subscription Redemption dialog also needs the proper icon.

Comment 4 Bryan Kearney 2012-10-30 19:14:42 UTC
fixed in master at 3f3ebfd2c6c9fcdb08e8cab6b99ed7cfbba00f49

Comment 6 Adrian Likins 2012-11-08 22:48:33 UTC
commit 3f3ebfd2c6c9fcdb08e8cab6b99ed7cfbba00f49
Author: Bryan Kearney <bkearney>
Date:   Tue Oct 30 14:35:32 2012 -0400

    855050: Set the icon-name property on all dialogs and windows

Comment 8 Matt Reid 2012-11-12 18:43:47 UTC
I still see the generic icon on:
Date Picker from All Available Subs tab
License Info from the About dialog

This was with subscription-manager-1.1.1.5-1.git.14.ae9fffd.

Looks like almost all of the generic icons are gone now!

If we go back and fix the License dialog icon as part of this bz, we can close out https://bugzilla.redhat.com/show_bug.cgi?id=839318

Comment 9 John Sefler 2012-12-07 23:21:50 UTC
Created attachment 659646 [details]
still showing generic icon in the date picker dialog decoration

[root@jsefler-6 ~]# rpm -q subscription-manager-gui
subscription-manager-gui-1.1.11-1.el6.x86_64

Moving status back to ASSIGNED/FailedQA

Comment 12 Bryan Kearney 2013-09-03 18:19:07 UTC
this is in 1.9.2

Comment 13 John Sefler 2013-09-20 17:55:39 UTC
Created attachment 800594 [details]
FailedQA

[root@jsefler-6 ~]# rpm -q subscription-manager-gui
subscription-manager-gui-1.9.6-1.el6.x86_64

Comment 15 Devan Goodwin 2014-01-30 13:43:38 UTC
These icons are not even visible in RHEL 7 due to the changes in GTK.

Deferring to RHEL 6.6 where they can actually be seen. Removing RHEL 7 acks.

Comment 18 RHEL Program Management 2014-05-28 16:49:10 UTC
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux release.  Product Management has
requested further review of this request by Red Hat Engineering, for
potential inclusion in a Red Hat Enterprise Linux release for currently
deployed products.  This request is not yet committed for inclusion in
a release.

Comment 19 Carter Kozak 2014-05-30 17:38:15 UTC
commit 1e52e8745eeee76103e7dbe5779752287514b59c
Author: ckozak <ckozak>
Date:   Wed May 28 12:29:36 2014 -0400

    855050: set default fallback window icon

Comment 20 John Sefler 2014-06-23 21:34:03 UTC
Created attachment 911594 [details]
screenshots showing subscription-manager-gui dialogs with the expected icons circled

Verifying Version...
[root@jsefler-5 ~]# rpm -q subscription-manager-gui
subscription-manager-gui-1.11.3-6.el5

Comment 23 errata-xmlrpc 2014-09-16 00:21:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1225.html