Description of problem: We were still missing it for some dialogs, but when we switched over to using the proper PNGs instead of the SVG, we lost some of the progress we had made on eliminating the generic icon from being used in our dialogs. Dialogs I've seen in the newer builds that are using the generic window icon: About License Import Cert System Facts Proxy Config System Preferences Unregister Confirmation Unsubscribe Confirmation System Registration No action needed dialog (when green and try to auto-sub) Must manually subscribe dialog (cases where auto-sub fails) That might not be everything, maybe there's an easy way to double-check in the code? Should be most of them at least. If it helps to see an implemented example, the Filters and Searching (Update button) dialogs use the right icon. Version - 1.0.17-1.git.0.279356f
Created attachment 610384 [details] Generic Icon
Created attachment 610385 [details] Proper Icon
The Subscription Redemption dialog also needs the proper icon.
fixed in master at 3f3ebfd2c6c9fcdb08e8cab6b99ed7cfbba00f49
commit 3f3ebfd2c6c9fcdb08e8cab6b99ed7cfbba00f49 Author: Bryan Kearney <bkearney> Date: Tue Oct 30 14:35:32 2012 -0400 855050: Set the icon-name property on all dialogs and windows
I still see the generic icon on: Date Picker from All Available Subs tab License Info from the About dialog This was with subscription-manager-1.1.1.5-1.git.14.ae9fffd. Looks like almost all of the generic icons are gone now! If we go back and fix the License dialog icon as part of this bz, we can close out https://bugzilla.redhat.com/show_bug.cgi?id=839318
Created attachment 659646 [details] still showing generic icon in the date picker dialog decoration [root@jsefler-6 ~]# rpm -q subscription-manager-gui subscription-manager-gui-1.1.11-1.el6.x86_64 Moving status back to ASSIGNED/FailedQA
this is in 1.9.2
Created attachment 800594 [details] FailedQA [root@jsefler-6 ~]# rpm -q subscription-manager-gui subscription-manager-gui-1.9.6-1.el6.x86_64
These icons are not even visible in RHEL 7 due to the changes in GTK. Deferring to RHEL 6.6 where they can actually be seen. Removing RHEL 7 acks.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux release for currently deployed products. This request is not yet committed for inclusion in a release.
commit 1e52e8745eeee76103e7dbe5779752287514b59c Author: ckozak <ckozak> Date: Wed May 28 12:29:36 2014 -0400 855050: set default fallback window icon
Created attachment 911594 [details] screenshots showing subscription-manager-gui dialogs with the expected icons circled Verifying Version... [root@jsefler-5 ~]# rpm -q subscription-manager-gui subscription-manager-gui-1.11.3-6.el5
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-1225.html