Bug 855625

Summary: engine: no warning is issued that only vm configuration will be exported when exporting a vm with no disk/shared disk/direct lun
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: ovirt-engineAssignee: Michal Skrivanek <michal.skrivanek>
Status: CLOSED CURRENTRELEASE QA Contact: Elad <ebenahar>
Severity: high Docs Contact:
Priority: high    
Version: 3.1.0CC: acathrow, dyasny, hateya, iheim, lpeer, michal.skrivanek, mkenneth, ofrenkel, Rhev-m-bugs, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.2.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: virt
Fixed In Version: sf10 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 915537, 922807    
Attachments:
Description Flags
Sample export dialog
none
New export dialog
none
New create snapshot dialog
none
New Create template dialog none

Description Dafna Ron 2012-09-09 12:15:18 UTC 
Description of problem:

when we export a vm with no disk/shared disk or direct lun, the export succeeds only for vm's configuration. 
if no warning is issued user might think that the images are exported and will be surprised when he finds out this is not the case. 

Version-Release number of selected component (if applicable):

si17

How reproducible:

100%

Steps to Reproduce:
1. create a vm with shared disk
2. create a vm with direct lun
3. create a vm with no disks
4. export the vms
  
Actual results:

vm's will be exported without the disks and with no warning. 

Expected results:

if vm has no disks, shared disk or direct lun please issue a warning (like we have when the vm already exists in the export domain) which the user will have to approve. 

Additional info:

when we export a vm that already exists we see the following: 

VM(s): • Direct_Lun already exist on the target Export Domain. If you want to override them, please check the 'Force Override' check-box.

speaking to Miki she would like to see something like that when we exclude the direct lun/shared disk or vm has no images.
Comment 1 Michal Skrivanek 2012-10-22 11:39:40 UTC 
do you really insist on confirmation check-box? Wouldn't that be too much annoying? Isn't it enough to have a red warning text pretty much similar as the one presented when the export domain doesn't exist
Comment 2 Dafna Ron 2012-10-22 12:03:23 UTC 
personally I do not think that its enough, but its not my call :)
this is a PM decision.
Comment 3 Barak 2012-12-03 11:33:05 UTC 
Andrew, Simon ?
Please comment.
Comment 4 Andrew Cathrow 2012-12-03 11:41:57 UTC 
Warning is enough.
Moving to 3.2
Comment 5 Libor Spevak 2013-01-15 15:29:53 UTC 
Created attachment 678844 [details]
Sample export dialog
Comment 6 Libor Spevak 2013-01-15 15:31:37 UTC 
Propose please a convenient text for the message...

e.g.
Disk(s):\n{0} will not be part of the exported snapshot.
or
Disk(s):\n{0} will not be part of the exported virtual machine.

Appending sample screenshot of the solution....
Comment 7 Michal Skrivanek 2013-01-16 08:46:26 UTC 
text seems ok to me, just layout formatting. pls attach new snapshot
Comment 8 Dafna Ron 2013-01-16 08:54:35 UTC 
(In reply to comment #7)
> text seems ok to me, just layout formatting. pls attach new snapshot

I am not sure what you need me to attach.
in sf3 there is still no warning issued when exporting a vm with a shared disk.
Comment 9 Libor Spevak 2013-01-17 10:51:39 UTC 
Created attachment 680124 [details]
New export dialog
Comment 10 Libor Spevak 2013-01-17 10:52:07 UTC 
Created attachment 680125 [details]
New create snapshot dialog
Comment 11 Libor Spevak 2013-01-17 10:52:42 UTC 
Created attachment 680126 [details]
New Create template dialog
Comment 12 Libor Spevak 2013-01-17 11:46:17 UTC 
I6a183931e36ccd4668225ad206edc4a5e58795e3
Comment 13 Libor Spevak 2013-02-04 20:54:16 UTC 
Merged upstream master 3.3
056aad683e6064db5149003035498143a6ee953a
Comment 14 Libor Spevak 2013-02-06 14:54:30 UTC 
Merged downstream 3.2

3908b50a3e1d5848577ff818eb042e2644ff157a
Comment 15 Elad 2013-02-21 10:35:58 UTC 
I checked on SF7. When I export VM without disks, still, there is no warning.
Comment 16 Libor Spevak 2013-02-21 14:26:31 UTC 
Missing check pushed for review upstream.

New messages added:
- No disk will be part of the exported virtual machine.
- No disk will be part of the exported template.
- No disk will be part of the exported snapshot.
Comment 17 Michal Skrivanek 2013-02-21 14:46:03 UTC 
looking at the patches - so what's the message when I'm e.g. exporting a VM with directly attached LUN?
Comment 18 Libor Spevak 2013-02-22 12:01:21 UTC 
Current messages unified to 3 forms now:

There are no exportable disks, only the configuration will be exported.
Shared disk(s) will not be exported: {0}.
Direct LUN disk(s) will not be exported: {0}.

{0}..comma-separated list of disk labels.

0-3 of them can be shown for VM export, VM template, VM snapshot dialogs.
Comment 20 Elad 2013-03-14 15:20:49 UTC 
Verified on SF10. Warning was issued when VM's with direct LUN, shared disk and with no disks have been exported.
Comment 22 Itamar Heim 2013-06-11 08:42:01 UTC 
3.2 has been released
Comment 23 Itamar Heim 2013-06-11 08:42:01 UTC 
3.2 has been released
Comment 24 Itamar Heim 2013-06-11 08:42:04 UTC 
3.2 has been released
Comment 25 Itamar Heim 2013-06-11 08:49:22 UTC 
3.2 has been released