Description of problem: when we export a vm with no disk/shared disk or direct lun, the export succeeds only for vm's configuration. if no warning is issued user might think that the images are exported and will be surprised when he finds out this is not the case. Version-Release number of selected component (if applicable): si17 How reproducible: 100% Steps to Reproduce: 1. create a vm with shared disk 2. create a vm with direct lun 3. create a vm with no disks 4. export the vms Actual results: vm's will be exported without the disks and with no warning. Expected results: if vm has no disks, shared disk or direct lun please issue a warning (like we have when the vm already exists in the export domain) which the user will have to approve. Additional info: when we export a vm that already exists we see the following: VM(s): • Direct_Lun already exist on the target Export Domain. If you want to override them, please check the 'Force Override' check-box. speaking to Miki she would like to see something like that when we exclude the direct lun/shared disk or vm has no images.
do you really insist on confirmation check-box? Wouldn't that be too much annoying? Isn't it enough to have a red warning text pretty much similar as the one presented when the export domain doesn't exist
personally I do not think that its enough, but its not my call :) this is a PM decision.
Andrew, Simon ? Please comment.
Warning is enough. Moving to 3.2
Created attachment 678844 [details] Sample export dialog
Propose please a convenient text for the message... e.g. Disk(s):\n{0} will not be part of the exported snapshot. or Disk(s):\n{0} will not be part of the exported virtual machine. Appending sample screenshot of the solution....
text seems ok to me, just layout formatting. pls attach new snapshot
(In reply to comment #7) > text seems ok to me, just layout formatting. pls attach new snapshot I am not sure what you need me to attach. in sf3 there is still no warning issued when exporting a vm with a shared disk.
Created attachment 680124 [details] New export dialog
Created attachment 680125 [details] New create snapshot dialog
Created attachment 680126 [details] New Create template dialog
I6a183931e36ccd4668225ad206edc4a5e58795e3
Merged upstream master 3.3 056aad683e6064db5149003035498143a6ee953a
Merged downstream 3.2 3908b50a3e1d5848577ff818eb042e2644ff157a
I checked on SF7. When I export VM without disks, still, there is no warning.
Missing check pushed for review upstream. New messages added: - No disk will be part of the exported virtual machine. - No disk will be part of the exported template. - No disk will be part of the exported snapshot.
looking at the patches - so what's the message when I'm e.g. exporting a VM with directly attached LUN?
Current messages unified to 3 forms now: There are no exportable disks, only the configuration will be exported. Shared disk(s) will not be exported: {0}. Direct LUN disk(s) will not be exported: {0}. {0}..comma-separated list of disk labels. 0-3 of them can be shown for VM export, VM template, VM snapshot dialogs.
Verified on SF10. Warning was issued when VM's with direct LUN, shared disk and with no disks have been exported.
3.2 has been released