Bug 856108

Summary: Redundant events about VLAN networks are reported to audit log
Product: Red Hat Enterprise Virtualization Manager Reporter: Moti Asayag <masayag>
Component: ovirt-engineAssignee: Moti Asayag <masayag>
Status: CLOSED CURRENTRELEASE QA Contact: GenadiC <gcheresh>
Severity: low Docs Contact:
Priority: low    
Version: 3.1.0CC: acathrow, dyasny, iheim, lpeer, mavital, Rhev-m-bugs, yeylon, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: network
Fixed In Version: SI19.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-04 20:06:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Moti Asayag 2012-09-11 08:32:18 UTC
Description of problem:
An event-log is created for two types of VLAN network event-types:
1. For host which misses a network having vlan-tag.
2. For host with a vlan network out-of-sync with the vlan-id defined on the network on engine.

The first event is not relevant since is covered by the validation for a required network existence on host (regardless having vlan-tag)

The second event is already covered by the network-no-in-sync event.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
For event 1:
1. Create a network with vlan-id as non-required.
2. Perform any action via setupNetworks and check the event log.

For event 2:
1. Create a network with vlan-tag and attach to host.
2. Change manually the attached interface vlan-id.
3. Perform any action via setupNetworks not related to this interface so getCapabilities is invoked.
4. Check the events printed to the audit log.
  
Actual results:
event 1:
zeus02 is missing vlan id: 9 that is expected by the cluster
	
event 2:
zeus02 is having wrong vlan id: 5, expected vlan id: 222


Expected results:
The first event shouldn't be recorded.
Instead of the second event, the following message is expected in events-log:
Host zeus02's following network(s) are not synchronized with their Logical Network configuration: VLAN_MTU_5000.

Comment 1 Moti Asayag 2012-09-11 14:12:22 UTC
A suggested patch:

http://gerrit.ovirt.org/#/c/7923/

Comment 3 GenadiC 2012-10-02 13:56:40 UTC
Verified in SI19.1