Bug 857348
| Summary: | crash when network online status changes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabrice Bellet <fabrice> | ||||
| Component: | liferea | Assignee: | Steven M. Parrish <smparrish> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 17 | CC: | emmanuel, ondra.pelech, scorpy_sk, smparrish, yaneti | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-10-09 10:02:43 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
This should probably be brought up in the upstream bug tracker.
Maybe the patch itself could be reduced to
static void
liferea_htmlview_finalize (GObject *object)
{
+ g_signal_handlers_disconnect_by_data (network_monitor_get (), object);
+
G_OBJECT_CLASS (parent_class)->finalize (object);
}
I don't use liferea tabs so I've not seen it crash like that. Could you test this?
Yes. I stress tested it with your patch, and it seems it's stable too. Thanks! Fabrice, have you submitted this to upstream's bug tracker? Thanks for testing. I've submitted this upstream. https://sourceforge.net/tracker/?func=detail&aid=3567715&group_id=87005&atid=581686 Thinking of filing an update with this and 1.8.8 liferea-1.8.8-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/liferea-1.8.8-1.fc18 liferea-1.8.8-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/liferea-1.8.8-1.fc17 Package liferea-1.8.8-1.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing liferea-1.8.8-1.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-14154/liferea-1.8.8-1.fc17 then log in and leave karma (feedback). liferea-1.8.8-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. liferea-1.8.8-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. *** Bug 861557 has been marked as a duplicate of this bug. *** liferea-1.8.8-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/liferea-1.8.8-2.fc17 I forgot to actually apply the patch in the previous update. Sorry. Package liferea-1.8.8-2.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing liferea-1.8.8-2.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-15093/liferea-1.8.8-2.fc17 then log in and leave karma (feedback). The update already hit stable so I am closing again. |
Created attachment 612752 [details] Disconnect signals when finalizing htmlview liferea frequently crashes when manipulating htmlviews (opening/closing new tabs) while the network online status changes. This is caused because the signal notifying online status is not properly disconnected when the htmlview is removed. Suggested patch follows.