Bug 857540
| Summary: | pid and log file path violates system path rules, and config files NOT owned by 'root' | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | matthew patton <pattonme> | ||||
| Component: | jabberd | Assignee: | Adrian Reber <adrian> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | el6 | CC: | adrian, dmaphy, mcepl, mcepl, pattonme | ||||
| Target Milestone: | --- | Flags: | mcepl:
needinfo?
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | jabberd-2.4.0-4.el6 jabberd-2.4.0-4.fc25 jabberd-2.4.0-4.el7 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-10-06 02:46:32 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 995404 [details]
suggested patch
Hi, just drive-by fixing of old bug. If you are still around could you please test packages from http://koji.fedoraproject.org/koji/taskinfo?taskID=9078051, please? Thanks for patch. If you are applying this on the EL6 branch it probably also needs to be applied on the other active branches. The build failed apparently. But the patch seems reasonable. One more effort: EPEL-6: http://koji.fedoraproject.org/koji/taskinfo?taskID=9441142 EPEL-7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9441167 F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=9441389 This at least builds and I would love to see whether it works for you as well. Once I get your OK, I will make it into proper Fedora/EPEL builds. jabberd-2.4.0-4.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2964816bab jabberd-2.4.0-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-62ecf20b8f jabberd-2.4.0-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-47a1c87c0e jabberd-2.4.0-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. jabberd-2.4.0-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. jabberd-2.4.0-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |
Jabberd log and pid files are flagrantly misplaced in /var/lib/jabberd instead of /var/{run,log}/jabberd. Jabberd logging is set to syslog and facility local3 which is improper. It should be 'daemon' like everything else. Since many sysadmins will deliberately and with good reason filter out 'local0-7' from being logged or will otherwise pay it little attention, jabberd failures will be ignored or not easily ascertained. Finally, no daemon should EVER own it's configuration files. Yet all the files in /etc/jabberd including the directory are uid=jabber. They all properly should be uid=root. gid=jabber is fine. The initscript also makes assumptions on PIDFILE names. The proper thing to do is to either parse the *.xml files for <pidfile> stanzas, or better yet, force the value by running 'sed -e' against the *.xml files according to what the initscript is expecting. Those values can furthermore be influenced by /etc/sysconfig/jabberd. Version-Release number of selected component (if applicable): 2.2.14-3.el6 How reproducible: always Actual results: Expected results: Additional info: