Bug 857540 - pid and log file path violates system path rules, and config files NOT owned by 'root' [NEEDINFO]
pid and log file path violates system path rules, and config files NOT owned ...
Status: CLOSED ERRATA
Product: Fedora EPEL
Classification: Fedora
Component: jabberd (Show other bugs)
el6
Unspecified Unspecified
unspecified Severity medium
: ---
: ---
Assigned To: Adrian Reber
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-14 15:06 EDT by matthew patton
Modified: 2016-12-10 00:19 EST (History)
4 users (show)

See Also:
Fixed In Version: jabberd-2.4.0-4.el6 jabberd-2.4.0-4.fc25 jabberd-2.4.0-4.el7
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-10-05 22:46:32 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mcepl: needinfo?


Attachments (Terms of Use)
suggested patch (5.50 KB, patch)
2015-02-25 19:49 EST, Matěj Cepl
no flags Details | Diff

  None (edit)
Description matthew patton 2012-09-14 15:06:32 EDT
Jabberd log and pid files are flagrantly misplaced in /var/lib/jabberd instead of /var/{run,log}/jabberd.

Jabberd logging is set to syslog and facility local3 which is improper. It should be 'daemon' like everything else. Since many sysadmins will deliberately and with good reason filter out 'local0-7' from being logged or will otherwise pay it little attention, jabberd failures will be ignored or not easily ascertained.

Finally, no daemon should EVER own it's configuration files. Yet all the files in /etc/jabberd including the directory are uid=jabber. They all properly should be uid=root. gid=jabber is fine.

The initscript also makes assumptions on PIDFILE names. The proper thing to do is to either parse the *.xml files for <pidfile> stanzas, or better yet, force the value by running 'sed -e' against the *.xml files according to what the initscript is expecting. Those values can furthermore be influenced by /etc/sysconfig/jabberd.

Version-Release number of selected component (if applicable):

2.2.14-3.el6

How reproducible:

always
  
Actual results:


Expected results:


Additional info:
Comment 1 Matěj Cepl 2015-02-25 19:49:46 EST
Created attachment 995404 [details]
suggested patch
Comment 2 Matěj Cepl 2015-02-25 19:52:27 EST
Hi,

just drive-by fixing of old bug. If you are still around could you please test packages from http://koji.fedoraproject.org/koji/taskinfo?taskID=9078051, please?
Comment 3 Adrian Reber 2015-02-27 09:33:31 EST
Thanks for patch. If you are applying this on the EL6 branch it probably also needs to be applied on the other active branches.
Comment 4 matthew patton 2015-02-27 11:41:37 EST
The build failed apparently. But the patch seems reasonable.
Comment 5 Matěj Cepl 2015-04-08 18:17:32 EDT
One more effort:

EPEL-6: http://koji.fedoraproject.org/koji/taskinfo?taskID=9441142
EPEL-7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9441167
F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=9441389

This at least builds and I would love to see whether it works for you as well. Once I get your OK, I will make it into proper Fedora/EPEL builds.
Comment 6 Fedora Update System 2016-10-05 09:17:12 EDT
jabberd-2.4.0-4.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2964816bab
Comment 7 Fedora Update System 2016-10-05 09:19:33 EDT
jabberd-2.4.0-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-62ecf20b8f
Comment 8 Fedora Update System 2016-10-05 16:30:13 EDT
jabberd-2.4.0-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-47a1c87c0e
Comment 9 Fedora Update System 2016-10-05 22:46:32 EDT
jabberd-2.4.0-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2016-12-09 17:25:25 EST
jabberd-2.4.0-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2016-12-10 00:19:49 EST
jabberd-2.4.0-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.