Bug 857633

Summary: Proxy settings don't work in Grip
Product: [Fedora] Fedora Reporter: David Waring <ribenakid>
Component: gripAssignee: Adrian Reber <adrian>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 17CC: adrian, manuel.wolfshant
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-09-20 20:30:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to fix string pointers passed to curl_easy_setopt() and fix initialisation of user string. none

Description David Waring 2012-09-15 10:31:14 UTC
Created attachment 613230 [details]
Patch to fix string pointers passed to curl_easy_setopt() and fix initialisation of user string.

Description of problem:
The proxy settings don't work in Grip. This is due to Grip passing the wrong pointer to curl_easy_setopt().

Version-Release number of selected component (if applicable):
grip-3.2.0-33.fc17

How reproducible:
Always

Steps to Reproduce:
1. Start grip
2. Configure proxy settings
3. Observe via strace that DNS lookups are for garbled host names
  
Actual results:
Grip doesn't find disc info from cddb

Expected results:
Grip should retrieve disc info from cddb via configured proxy

Additional info:
Patch included to fix proxy string and also noticed user info was wrong too. Tested with local rebuild of RPM including this patch as patch9.

Comment 1 Fedora Update System 2012-09-15 19:15:26 UTC
grip-3.2.0-41.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/grip-3.2.0-41.fc18

Comment 2 Fedora Update System 2012-09-15 19:16:47 UTC
grip-3.2.0-41.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/grip-3.2.0-41.fc17

Comment 3 Adrian Reber 2012-09-15 19:18:33 UTC
Thanks for the bug report and the patch. Applied.

Comment 4 Fedora Update System 2012-09-16 19:16:54 UTC
Package grip-3.2.0-41.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing grip-3.2.0-41.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-13988/grip-3.2.0-41.fc18
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2012-09-20 20:30:46 UTC
grip-3.2.0-41.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2012-09-26 09:05:27 UTC
grip-3.2.0-41.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.