Bug 859270

Summary: Review Request: php-symfony2-Filesystem - Symfony2 Filesystem Component
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, notting, package-review
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-17 16:58:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 814994    
Bug Blocks:    
Attachments:
Description Flags
bootstrap.php
none
859270-php-symfony2-Filesystem/php-symfony2-Filesystem-review.txt none

Description Shawn Iwinski 2012-09-21 00:24:30 UTC 
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-Filesystem.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-Filesystem-2.1.2-1.fc17.src.rpm

Description:
The Filesystem component provides basic utilities for the filesystem.

Fedora Account System Username: siwinski

Distributions: EPEL 6, F16+
Comment 1 Remi Collet 2012-09-21 05:29:03 UTC 
Quick notes, which affects "all" synfony 2.1 packages

- phpunit.xml.dist and Tests/* sould be role="test", so install in %{pear_testdir}
- CHANGELOG.md should be role="doc" 

sed -e '/CHANGELOG.md/s/role="php"/role="doc"/' \
    -e '/phpunit.xml.dist/s/role="php"/role="test"/' \
    -e '/Tests/s/role="php"/role="test"/' \
    -i package.xml

Of course, this should be reported to upstream

- as tests are provided, should be run in %check

%check
cd %{pear_name}-%{version}/Symfony/Component/%{pear_name}/Tests
phpunit  --bootstrap bootstrap.php .

N.B. : Yaml could not run test in %check, because it depends on phpunit, which depends use Yaml (see the diff I sent you)
Comment 2 Remi Collet 2012-09-21 05:56:09 UTC 
Created attachment 615284 [details]
bootstrap.php

Another small issue with the test suite provided: tThe provided "bootstrap" only allow us to run test from the source tree, but not from installation tree.

The attached version works in both. Please test it.
It should also work for all components, not specific to this one.

Probably, you can also propose this to upstream.
Comment 3 Remi Collet 2012-10-06 16:37:45 UTC 
Missing requires : php-posix (at least for test)
Comment 4 Shawn Iwinski 2012-10-08 22:33:35 UTC 
Updated per comments.

- Added php-posix require
- Added PEAR package.xml modificaions
- Added patch for tests' bootstrap.php
- Added tests (%check)

Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-Filesystem.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-Filesystem-2.1.2-2.fc17.src.rpm
Comment 5 Remi Collet 2012-10-10 15:19:55 UTC 
Created attachment 624957 [details]
859270-php-symfony2-Filesystem/php-symfony2-Filesystem-review.txt

Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24
Comment 6 Remi Collet 2012-10-10 15:21:43 UTC 
Note : typo in %changelog : modificaions (please fix after import)

No blocker

=== APPROVED ===
Comment 7 Shawn Iwinski 2012-10-11 22:02:39 UTC 
New Package SCM Request
=======================
Package Name: php-symfony2-Filesystem
Short Description: Symfony2 Filesystem Component
Owners: siwinski
Branches: f16 f17 f18 el6
InitialCC:
Comment 8 Gwyn Ciesla 2012-10-12 11:29:54 UTC 
Git done (by process-git-requests).