Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-Filesystem.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-Filesystem-2.1.2-1.fc17.src.rpm Description: The Filesystem component provides basic utilities for the filesystem. Fedora Account System Username: siwinski Distributions: EPEL 6, F16+
Quick notes, which affects "all" synfony 2.1 packages - phpunit.xml.dist and Tests/* sould be role="test", so install in %{pear_testdir} - CHANGELOG.md should be role="doc" sed -e '/CHANGELOG.md/s/role="php"/role="doc"/' \ -e '/phpunit.xml.dist/s/role="php"/role="test"/' \ -e '/Tests/s/role="php"/role="test"/' \ -i package.xml Of course, this should be reported to upstream - as tests are provided, should be run in %check %check cd %{pear_name}-%{version}/Symfony/Component/%{pear_name}/Tests phpunit --bootstrap bootstrap.php . N.B. : Yaml could not run test in %check, because it depends on phpunit, which depends use Yaml (see the diff I sent you)
Created attachment 615284 [details] bootstrap.php Another small issue with the test suite provided: tThe provided "bootstrap" only allow us to run test from the source tree, but not from installation tree. The attached version works in both. Please test it. It should also work for all components, not specific to this one. Probably, you can also propose this to upstream.
Missing requires : php-posix (at least for test)
Updated per comments. - Added php-posix require - Added PEAR package.xml modificaions - Added patch for tests' bootstrap.php - Added tests (%check) Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-Filesystem.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-Filesystem-2.1.2-2.fc17.src.rpm
Created attachment 624957 [details] 859270-php-symfony2-Filesystem/php-symfony2-Filesystem-review.txt Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24
Note : typo in %changelog : modificaions (please fix after import) No blocker === APPROVED ===
New Package SCM Request ======================= Package Name: php-symfony2-Filesystem Short Description: Symfony2 Filesystem Component Owners: siwinski Branches: f16 f17 f18 el6 InitialCC:
Git done (by process-git-requests).