Bug 860521 (mate-session-manager)

Summary: Review Request: mate-session-manager - MATE Desktop session manager
Product: [Fedora] Fedora Reporter: Dan Mashal <dan.mashal>
Component: Package ReviewAssignee: Rex Dieter <rdieter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dan.mashal, marcus.moeller, notting, package-review, rdieter
Target Milestone: ---Flags: rdieter: fedora‑review+
limburgher: fedora‑cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-10-14 20:47:55 EDT Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 840149    

Comment 1 Jens Petersen 2012-09-28 02:05:10 EDT
Fails to build in koji for rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=4536257

+ ./autogen.sh
which: no mate-autogen in (/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/builddir/.local/bin:/builddir/bin)
You need to install mate-common from the MATE Git
RPM build errors:

Perhaps you need to BR mate-common?

Best to test building in mock or koji when submitting.
Comment 2 Dan Mashal 2012-09-29 15:08:22 EDT
Totally forgot mate-common. Thanks.
Comment 3 Dan Mashal 2012-09-29 16:44:09 EDT
OK fixed.

Please review.

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-session-manager.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-session-manager-1.4.0-3.fc17.src.rpm
Description: MATE Desktop session manager
Comment 4 Dan Mashal 2012-10-02 21:51:05 EDT
Per our conversation, fixed some of the scriptlets, and the licensing. There is a bug in mate-conf-1.4.0-19 works fine with mate-conf-1.4.0-14, we know what to fix with that one.

This one should be good to go.

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-session-manager.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-session-manager-1.4.0-4.fc17.src.rpm
Description: MATE Desktop session manager
Comment 5 Marcus Moeller 2012-10-03 06:59:01 EDT
This error is logged during login on a F18 installation with the above mate-session package installed:

mate-session[5574]: WARNING: Unable to determine session: Unable to lookup session information for process '5574'
mate-session[5574]: WARNING: Application 'marco.desktop' failed to register before timeout

Login takes quite long (about 10 seconds) and results in a desktop with one empty top panel (but I guess that may be related to mate-panel).
Comment 6 Dan Mashal 2012-10-03 16:37:29 EDT
^^install mate-panel and the rest of the RPMs
Comment 7 Rex Dieter 2012-10-03 18:49:57 EDT
naming: ok

sources: ok
7cac7ef39b72c814f549fa6f1f84a58d  mate-session-manager-1.4.0.tar.xz

license: ok

scriptlets: ok

1.  build: NOT ok, building locally I get:
Installed (but unpackaged) file(s) found:
/usr/share/doc/mate-session/dbus/mate-session.html
So, I'd suggest you SHOULD add:
BuildRequires: docbook
and possibly add --enable-docbook-docs build flag too


1's not a blocker, though, so APPROVED
Comment 8 Dan Mashal 2012-10-03 18:56:35 EDT
Thanks!
Comment 9 Dan Mashal 2012-10-03 18:57:53 EDT
New Package SCM Request
=======================
Package Name: mate-session-manager
Short Description: MATE Desktop session manager
Owners: rdieter vicodan
Branches: f16 f17 f18
Comment 10 Jon Ciesla 2012-10-04 07:22:00 EDT
Git done (by process-git-requests).
Comment 11 Fedora Update System 2012-10-04 14:53:33 EDT
mate-session-manager-1.4.0-4.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-session-manager-1.4.0-4.fc17
Comment 12 Fedora Update System 2012-10-04 14:54:21 EDT
mate-session-manager-1.4.0-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mate-session-manager-1.4.0-4.fc18
Comment 13 Fedora Update System 2012-10-04 20:56:40 EDT
mate-session-manager-1.4.0-4.fc17 has been pushed to the Fedora 17 testing repository.
Comment 14 Dan Mashal 2012-10-14 20:47:55 EDT
not sure why bodhi isn't closing bugs but both f18 and f17 packages have been pushed to stable.