Bug 860625

Summary:	Review Request: pycanberra - A very basic (and incomplete) wrapper for libcanberra
Product:	[Fedora] Fedora	Reporter:	Mathieu Bridon <bochecha>
Component:	Package Review	Assignee:	Adel Gadllah <adel.gadllah>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	adel.gadllah, gwync, notting, package-review
Target Milestone:	---	Flags:	adel.gadllah: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-09-27 03:46:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	857180

Description Mathieu Bridon 2012-09-26 10:36:45 UTC

Spec URL: http://bochecha.fedorapeople.org/packages/pycanberra.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/pycanberra-0-0.1.git65c3b3f.fc18.src.rpm

Description:
A very basic (and incomplete) wrapper for libcanberra.

This is necessary until libcanberra gets proper GObject Introspection support.

Fedora Account System Username: bochecha

Comment 1 Adel Gadllah 2012-09-26 10:54:21 UTC

Looks good, rpmlint output is just noise:

-------------------
pycanberra.src: W: spelling-error Summary(en_US) libcanberra -> Canberra
pycanberra.src: W: spelling-error %description -l en_US libcanberra -> Canberra
pycanberra.src: W: invalid-url Source0: pycanberra-git.65c3b3f.tar.xz
pycanberra.spec: W: invalid-url Source0: pycanberra-git.65c3b3f.tar.xz
pycanberra.noarch: W: spelling-error Summary(en_US) libcanberra -> Canberra
pycanberra.noarch: W: spelling-error %description -l en_US libcanberra -> Canberra
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
--------------------

(You could just remove the empty %build but that would trigger another rpmlint warning so just leave it as is).

Comment 2 Mathieu Bridon 2012-09-26 11:02:23 UTC

Thanks Adel!

New Package SCM Request
=======================
Package Name: pycanberra
Short Description: A very basic (and incomplete) wrapper for libcanberra
Owners: bochecha
Branches: devel f18
InitialCC:

Comment 3 Gwyn Ciesla 2012-09-26 11:28:33 UTC

Git done (by process-git-requests).

Adel, please take ownership of review BZs, thanks!

Comment 4 Gwyn Ciesla 2012-09-26 11:29:49 UTC

Also, please post more detail about exactly what you reviewed, etc.  There are several templates available on the wiki as a starting point.

Comment 5 Gwyn Ciesla 2012-09-26 13:03:51 UTC

Fixing flag.

Comment 6 Mathieu Bridon 2012-09-27 03:46:12 UTC

Thanks Jon!

Built in all branches, closing.