Bug 860625 - Review Request: pycanberra - A very basic (and incomplete) wrapper for libcanberra
Review Request: pycanberra - A very basic (and incomplete) wrapper for libcan...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Adel Gadllah
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 857180
  Show dependency treegraph
 
Reported: 2012-09-26 06:36 EDT by Mathieu Bridon
Modified: 2012-09-26 23:46 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-09-26 23:46:12 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
adel.gadllah: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Mathieu Bridon 2012-09-26 06:36:45 EDT
Spec URL: http://bochecha.fedorapeople.org/packages/pycanberra.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/pycanberra-0-0.1.git65c3b3f.fc18.src.rpm

Description:
A very basic (and incomplete) wrapper for libcanberra.

This is necessary until libcanberra gets proper GObject Introspection support.

Fedora Account System Username: bochecha
Comment 1 Adel Gadllah 2012-09-26 06:54:21 EDT
Looks good, rpmlint output is just noise:

-------------------
pycanberra.src: W: spelling-error Summary(en_US) libcanberra -> Canberra
pycanberra.src: W: spelling-error %description -l en_US libcanberra -> Canberra
pycanberra.src: W: invalid-url Source0: pycanberra-git.65c3b3f.tar.xz
pycanberra.spec: W: invalid-url Source0: pycanberra-git.65c3b3f.tar.xz
pycanberra.noarch: W: spelling-error Summary(en_US) libcanberra -> Canberra
pycanberra.noarch: W: spelling-error %description -l en_US libcanberra -> Canberra
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
--------------------

(You could just remove the empty %build but that would trigger another rpmlint warning so just leave it as is).
Comment 2 Mathieu Bridon 2012-09-26 07:02:23 EDT
Thanks Adel!

New Package SCM Request
=======================
Package Name: pycanberra
Short Description: A very basic (and incomplete) wrapper for libcanberra
Owners: bochecha
Branches: devel f18
InitialCC:
Comment 3 Gwyn Ciesla 2012-09-26 07:28:33 EDT
Git done (by process-git-requests).

Adel, please take ownership of review BZs, thanks!
Comment 4 Gwyn Ciesla 2012-09-26 07:29:49 EDT
Also, please post more detail about exactly what you reviewed, etc.  There are several templates available on the wiki as a starting point.
Comment 5 Gwyn Ciesla 2012-09-26 09:03:51 EDT
Fixing flag.
Comment 6 Mathieu Bridon 2012-09-26 23:46:12 EDT
Thanks Jon!

Built in all branches, closing.

Note You need to log in before you can comment on or make changes to this bug.