Bug 860807
| Summary: | scheduled operation with params but no values set doesn't render | ||
|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | John Mazzitelli <mazz> |
| Component: | Core UI | Assignee: | John Mazzitelli <mazz> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.5 | CC: | ahovsepy, hrupp |
| Target Milestone: | --- | ||
| Target Release: | RHQ 4.6 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-04 07:27:56 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
fyi: that code snippet is found in: org.rhq.enterprise.gui.coregui.client.inventory.common.detail.operation.schedule.AbstractOperationScheduleDetailsView.refreshOperationParametersItem() git commit to master 83d01ea uh... this is weird. On JON 3.1.1, this actually works ok. The view shows "This operation does not take any parameters." But yet when built on AS7 branch after merged with master, the bug shows up. the description of this bug wasn't fully accurate. You need to select an operation that DOES have an operation, but the values are all unset and you never set them. for example, the RHQ Agent operation "Get Current Date/Time". I'm putting this back on ON_QA for QA just to test this again. Because its possible master was broken again. I committed what I think is a fix - it works for me now. verified w/wo setting params build:ff37cd9 Done in an old release, closing now. |
Schedule an operation to execute in the future. Go to the scheduled subtab, and click the link of the scheduled operation. You get an ugly red error and the rendering isn't correct. Problem is this: if (isNewRecord()) { ConfigurationTemplate defaultTemplate = parametersDefinition.getDefaultTemplate(); this.operationParameters = (defaultTemplate != null) ? defaultTemplate.createConfiguration() : new Configuration(); } else { } I have no idea why an empty else clause is here. This should be the body of the else clause: this.operationParameters = new Configuration(); I don't know if this is related to bug 852014 but hey, you never know.