Bug 860807 - scheduled operation with params but no values set doesn't render
Summary: scheduled operation with params but no values set doesn't render
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Core UI
Version: 4.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: RHQ 4.6
Assignee: John Mazzitelli
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-09-26 18:37 UTC by John Mazzitelli
Modified: 2013-09-04 07:27 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-09-04 07:27:56 UTC
Embargoed:

Attachments (Terms of Use)

Description John Mazzitelli 2012-09-26 18:37:07 UTC 
Schedule an operation to execute in the future. Go to the scheduled subtab, and click the link of the scheduled operation. You get an ugly red error and the rendering isn't correct.

Problem is this:

                if (isNewRecord()) {
                    ConfigurationTemplate defaultTemplate = parametersDefinition.getDefaultTemplate();
                    this.operationParameters = (defaultTemplate != null) ? defaultTemplate.createConfiguration()
                        : new Configuration();
                } else {

                }

I have no idea why an empty else clause is here. This should be the body of the else clause:

  this.operationParameters = new Configuration();

I don't know if this is related to bug 852014 but hey, you never know.
Comment 1 John Mazzitelli 2012-09-26 18:37:42 UTC 
fyi: that code snippet is found in: 

org.rhq.enterprise.gui.coregui.client.inventory.common.detail.operation.schedule.AbstractOperationScheduleDetailsView.refreshOperationParametersItem()
Comment 2 John Mazzitelli 2012-09-26 18:41:18 UTC 
git commit to master 83d01ea
Comment 3 John Mazzitelli 2012-09-26 18:58:16 UTC 
uh... this is weird. On JON 3.1.1, this actually works ok. The view shows "This operation does not take any parameters." But yet when built on AS7 branch after merged with master, the bug shows up.
Comment 4 John Mazzitelli 2012-09-26 19:26:36 UTC 
the description of this bug wasn't fully accurate. You need to select an operation that DOES have an operation, but the values are all unset and you never set them.

for example, the RHQ Agent operation "Get Current Date/Time".
Comment 5 John Mazzitelli 2012-09-26 20:11:29 UTC 
I'm putting this back on ON_QA for QA just to test this again. Because its possible master was broken again. I committed what I think is a fix - it works for me now.
Comment 6 Armine Hovsepyan 2013-05-30 09:28:22 UTC 
verified w/wo setting params
build:ff37cd9
Comment 7 Heiko W. Rupp 2013-09-04 07:27:56 UTC 
Done in an old release, closing now.
Note You need to log in before you can comment on or make changes to this bug.