Bug 861309

Summary: USB disks ignore configured address
Product: [Fedora] Fedora Reporter: Vladislav Bogdanov <bubble>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 17CC: berrange, clalancette, crobinso, itamar, jforbes, jyang, laine, libvirt-maint, veillard, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 985166 (view as bug list) Environment:
Last Closed: 2013-01-06 20:14:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 985166    
Attachments:
Description Flags
Honor <address/> node for USB disks with qemu
none
Allow USB disks to be connected to USB hub (qemu)
none
Allow USB disks to be connected to USB hub (qemu) (fix tests) none

Description Vladislav Bogdanov 2012-09-28 06:17:52 UTC 
Description of problem:
If one has USB disks configured for domain with explicit <address/>, libvirtd ignores that node when building qemu command line. So, disk are connected to the first free USB port implicitly by qemu.
That breaks other USB devices which have explicit <address/> - ports they should be connected to may be already occupied by disks.
I attach patch (libvirt-0.10.2-qemu-usb-storage-address.patch) to fix that.

Then, with that patch applied, if one has USB disk connected to the USB hub, qemu fails to start, because it does not know anything about hubs yet (when parsing disks).

I attach patch to fix that (libvirt-0.10.2-qemu-early-usb-hub-append.patch) together with fixes to tests suite (libvirt-0.10.2-qemu-early-usb-hub-append-tests-fix.patch)

Version-Release number of selected component (if applicable):
libvirt-0.10.2
qemu-1.2.0
Comment 1 Vladislav Bogdanov 2012-09-28 06:18:45 UTC 
Created attachment 618424 [details]
Honor <address/> node for USB disks with qemu
Comment 2 Vladislav Bogdanov 2012-09-28 06:19:39 UTC 
Created attachment 618425 [details]
Allow USB disks to be connected to USB hub (qemu)
Comment 3 Vladislav Bogdanov 2012-09-28 06:20:27 UTC 
Created attachment 618426 [details]
Allow USB disks to be connected to USB hub (qemu) (fix tests)

Patch is against 0.10.2
Comment 4 Cole Robinson 2012-10-21 21:05:33 UTC 
Awesome Vladislav, thanks for the patches! They look good to me but we do all our patch review on the upstream mailing list.

Can you send these to libvirt-list ? Following the git workflow here is preferred:

http://libvirt.org/hacking.html#patches
Comment 5 Cole Robinson 2012-10-27 17:01:50 UTC 
Patches posted upstream:

https://www.redhat.com/archives/libvir-list/2012-October/msg01551.html
Comment 6 Fedora Update System 2012-12-10 01:15:01 UTC 
libvirt-0.9.11.8-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libvirt-0.9.11.8-1.fc17
Comment 7 Fedora Update System 2012-12-16 20:03:40 UTC 
libvirt-0.9.11.8-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libvirt-0.9.11.8-2.fc17
Comment 8 Fedora Update System 2013-01-03 07:24:12 UTC 
libvirt-0.9.11.8-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.