Bug 863577
| Summary: | Clarify instructions on the 'reclaim disk space' dialog | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
| Component: | anaconda | Assignee: | Chris Lumens <clumens> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 18 | CC: | duffy, g.kaviyarasu, jonathan, vanmeeuwen+fedora |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | anaconda-18.15-1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-11-23 02:51:36 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adam Williamson
2012-10-05 21:03:40 UTC
Here's the text I would suggest: "There is enough free space available to complete this installation in pre-existing filesystems. While it's risky and we recommend that you back up your data first, you can recover that free disk space and make it available for this installation below." "You can (also) remove existing filesystems you no longer need to free up space for this installation. Removing a filesystem will permanently delete all of the data it contains." I reworded some things for grammar, and also so we don't have the distribution name embedded in the text. (Generally we try to avoid this since RHEL among other distros use anaconda.) If we have one message for both scenarios it should be: "You don't have enough free space available for this installation." "You can remove existing filesystems you no longer need to free up space for this installation. Removing a filesystem will permanently delete all of the data it contains." "There is also free space available in pre-existing filesystems. While it's risky and we recommend that you back up your data first, you can recover that free disk space and make it available for this installation below." There might be cases where the user doesn't have any shrinkable filesystems. Maybe on a mac that only has HFS+ partitions. In that case, the final paragraph in comment #2 should be dropped. Well I reckon the 'of' in 'all of the data' is unnecessary, but hey, strokes for folks =) I specifically stated in my text that shrinking will not normally cause data loss for a reason. If we don't specifically state this, and you imagine yourself as someone who knows nothing about partitioning reading that sentence, it seems somewhat unclear to me. If this 'recover free disk space from pre-existing filesystems' option is risky and you should back up data first, why would you do it? I figured that explicitly stating that when all goes well it preserves your existing data was useful information as to why you would ever choose that option. But if you think it's not needed, I don't mind. Chris - I note the patch for this puts the paragraphs the other way around (presumably because you don't have to deal with the 'also' issue then). I don't really mind that, but do note that I originally drafted it that way, and Mo specifically wanted to change the order so that the paragraph about resizing came first, and the paragraph about deleting came second - she particularly wanted that order, it wasn't just a random choice which way around to put them. anaconda-18.15-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.15-1.fc18 Package anaconda-18.15-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-18.15-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-15903/anaconda-18.15-1.fc18 then log in and leave karma (feedback). anaconda-18.16-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.16-1.fc18 Confirming fixed in 18.16. The text is now taking up quite a bit of space, though. Perhaps the first line - 'You don't have enough space for this installation', or something similar - doesn't need to be its own paragraph and could be merged in with the second paragraph (the one about deleting partitions) to save space. anaconda-18.17-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.17-1.fc18 Package anaconda-18.17-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-18.17-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-16295/anaconda-18.17-1.fc18 then log in and leave karma (feedback). back to VERIFIED. i should really file a bug with Luke that bodhi shouldn't change bugs from VERIFIED to ON_QA... anaconda-18.18-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.18-1.fc18 Package anaconda-18.18-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-18.18-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-16402/anaconda-18.18-1.fc18 then log in and leave karma (feedback). anaconda-18.19-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.19-1.fc18 Fixed since 18.19. |