Bug 865241

Summary:	Review Request: liblangtag - library to access tags for identifying languages
Product:	[Fedora] Fedora	Reporter:	David Tardon <dtardon>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	caolanm, dtardon, notting, package-review, panemade, tagoh
Target Milestone:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-10-11 11:42:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Tardon 2012-10-11 04:24:01 UTC

Spec URL: http://dtardon.fedorapeople.org/liblangtag.spec
SRPM URL: http://dtardon.fedorapeople.org/liblangtag-0.3-1.fc17.src.rpm
Description:
liblangtag is an interface library to access tags for identifying
languages.

Features:
* several subtag registry database supports:
  - language
  - extlang
  - script
  - region
  - variant
  - extension
  - grandfathered
  - redundant
* handling of the language tags
  - parser
  - matching
  - canonicalizing
Fedora Account System Username: dtardon

This will be a dependency for libreoffice 3.7 .

Comment 1 David Tardon 2012-10-11 04:31:10 UTC

Note to reviewer: several source files have a wrong license header (GPLv2+). That is by mistake, not by design, and it has been fixed upstream. Citation from private e-mail from the creator of these files:

"That's true. it may be introduced by using wrong template to insert the copyright notice by my emacs lisp. you should deal with it as LGPLv3+ as well as other files."

Comment 2 Parag AN(पराग) 2012-10-11 06:55:27 UTC

Review:

+ Koji scratch build for f19 is ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4580604

+ rpmlint on rpms gave
liblangtag.src: W: spelling-error %description -l en_US subtag -> sub tag, sub-tag, subtotal
liblangtag.src: W: spelling-error %description -l en_US extlang -> extolling
liblangtag.src: W: spelling-error %description -l en_US canonicalizing -> cannibalizing, canonizing, canalizing
liblangtag.x86_64: W: spelling-error %description -l en_US subtag -> sub tag, sub-tag, subtotal
liblangtag.x86_64: W: spelling-error %description -l en_US extlang -> extolling
liblangtag.x86_64: W: spelling-error %description -l en_US canonicalizing -> cannibalizing, canonizing, canalizing
liblangtag-devel.x86_64: W: no-documentation
liblangtag-devel.x86_64: E: incorrect-fsf-address /usr/include/liblangtag/lt-ext-module-data.h
4 packages and 0 specfiles checked; 1 errors, 7 warnings.
==> Good to contact upstream for incorrect-fsf-address if not fixed already in upstream

+ Source verified with upstream as (sha256sum)
47d3bf2824df0df409219d2061c99adac11019151315e5372f6844bba1f4de4d  liblangtag-0.3.tar.bz2
47d3bf2824df0df409219d2061c99adac11019151315e5372f6844bba1f4de4d  ../SOURCES/liblangtag-0.3.tar.bz2

+ Follows packaging guidelines

Suggestions:
1) Good to preserve timestamps of installed files from source as
make install DESTDIR=%{buildroot} INSTALL="install -p"

2) You can add author's reply as a text file in %doc for license clarification 

APPROVED.

Comment 3 David Tardon 2012-10-11 10:11:40 UTC

New Package SCM Request
=======================
Package Name: liblangtag
Short Description: An interface library to access tags for identifying languages
Owners: caolanm dtardon erack
Branches: f18
InitialCC:

Comment 4 Gwyn Ciesla 2012-10-11 10:52:19 UTC

Git done (by process-git-requests).