Bug 866312
| Summary: | Review Request: keybinder3 - Library for globally binding keys | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrick Griffis <tingping> |
| Component: | Package Review | Assignee: | Pierre-Yves Luyten <py> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | i, johannbg, notting, package-review, py, tingping |
| Target Milestone: | --- | Flags: | py:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | keybinder3-0.3.0-1.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-02 11:59:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Patrick Griffis
2012-10-15 05:02:50 UTC
Fixed some issues: SPEC: https://raw.github.com/gist/3890872/da70e52139b3998b9ea4f5fa74675c50145311a3/keybinder3.spec SRPM: https://dl.dropbox.com/u/5510351/keybinder3-0.3.0-2.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4606486 Removing needsponsor, as I have sponsored them in bug 855605. Minor changes: SPEC: https://gist.github.com/raw/3890872/4823dcd074db03207a2564dffe193dba4cc35cbc/keybinder3.spec SRPM: http://dl.dropbox.com/u/5510351/keybinder3-0.3.0-3.fc18.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4821621 Hello, I think you need to update kaizer.ze source0 Can you use tingping.de as storage? URL seems broken. Thanks for the quick update!
First comments
* SPECS/keybinder.spec:8: W: macro-in-comment %{version}
You can remove the old url.
* %description
* keybinder is a library for registering global keyboard shortcuts.
* Keybinder works with GTK-based applications using the X Window System.
U se Keybinder both cases
* Summary: Documenation for %{name}
typo, "Documentation", then again typo on the same word few lines below
License is good : MIT, Naming ok, Files installed at the right place and nothing forgot. Also review tools are fine. Thus, approving.
Provides
--------
keybinder3-devel:
keybinder3-devel
keybinder3-devel(x86-64)
pkgconfig(keybinder-3.0)
keybinder3-doc:
keybinder3-doc
keybinder3:
keybinder3
keybinder3(x86-64)
libkeybinder-3.0.so.0()(64bit)
*** Bug 963476 has been marked as a duplicate of this bug. *** New Package SCM Request ======================= Package Name: keybinder3 Short Description: A library for registering global keyboard shortcuts Owners: tingping Branches: f18 f19 Git done (by process-git-requests). keybinder3-0.3.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/keybinder3-0.3.0-1.fc18 keybinder3-0.3.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/keybinder3-0.3.0-1.fc19 The build are done, closing. keybinder3-0.3.0-1.fc18 has been pushed to the Fedora 18 stable repository. keybinder3-0.3.0-1.fc19 has been pushed to the Fedora 19 stable repository. |