Bug 866312 - Review Request: keybinder3 - Library for globally binding keys
Summary: Review Request: keybinder3 - Library for globally binding keys
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Pierre-Yves Luyten
QA Contact: Fedora Extras Quality Assurance
: 963476 (view as bug list)
Depends On:
TreeView+ depends on / blocked
Reported: 2012-10-15 05:02 UTC by Patrick Griffis
Modified: 2013-08-10 20:05 UTC (History)
6 users (show)

Fixed In Version: keybinder3-0.3.0-1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-08-02 11:59:58 UTC
py: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Patrick Griffis 2012-10-15 05:02:50 UTC
Spec URL: https://raw.github.com/gist/3890872/4d954405ce0fa230b743232ff8f0ac31c1f92d47/keybinder3.spec
SRPM URL: http://dl.dropbox.com/u/5510351/keybinder3-0.3.0-1.fc17.src.rpm
Description: keybinder is a library for registering global keyboard shortcuts. 
Keybinder works with GTK-based applications using the X Window System.

The library contains:
- A C library, libkeybinder
- Gobject-Introspection bindings

Fedora Account System Username: tingping
Still in need of sponsor: https://bugzilla.redhat.com/show_bug.cgi?id=855605

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4590052
rpmlint spec: 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint pkg: keybinder3.x86_64: W: spelling-error %description -l en_US keybinder -> key binder, key-binder, bindery
keybinder3.x86_64: W: spelling-error %description -l en_US Keybinder -> Key binder, Key-binder, Bindery
keybinder3.x86_64: W: spelling-error %description -l en_US libkeybinder -> bookbindery
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
(all false postivies)

Comment 2 Kevin Fenzi 2012-12-26 19:33:22 UTC
Removing needsponsor, as I have sponsored them in bug 855605.

Comment 4 Pierre-Yves Luyten 2013-07-29 23:29:51 UTC
Hello, I think you need to update kaizer.ze source0

Comment 5 Christopher Meng 2013-07-30 01:59:11 UTC
Can you use tingping.de as storage?

URL seems broken.

Comment 6 Patrick Griffis 2013-07-30 23:47:54 UTC
SPEC: http://fpaste.org/29123/13752279/

SRPM: http://db.tt/lR0jzPcD

Comment 7 Pierre-Yves Luyten 2013-07-31 19:46:27 UTC
Thanks for the quick update!
First comments

* SPECS/keybinder.spec:8: W: macro-in-comment %{version}

 You can remove the old url.

* %description
* keybinder is a library for registering global keyboard shortcuts.
* Keybinder works with GTK-based applications using the X Window System.

U se Keybinder both cases

* Summary: Documenation for %{name}

 typo, "Documentation", then again typo on the same word few lines below

Comment 8 Patrick Griffis 2013-08-01 00:42:33 UTC
SPEC: http://fpaste.org/29379/75317700/
SRPM: http://db.tt/7cjfl3Lz

Comment 9 Pierre-Yves Luyten 2013-08-01 06:14:49 UTC
License is good : MIT, Naming ok, Files installed at the right place and nothing forgot. Also review tools are fine. Thus, approving.




Comment 10 Pierre-Yves Luyten 2013-08-01 06:20:33 UTC
*** Bug 963476 has been marked as a duplicate of this bug. ***

Comment 11 Patrick Griffis 2013-08-01 09:37:42 UTC
New Package SCM Request
Package Name: keybinder3
Short Description: A library for registering global keyboard shortcuts
Owners: tingping
Branches: f18 f19

Comment 12 Gwyn Ciesla 2013-08-01 12:09:59 UTC
Git done (by process-git-requests).

Comment 13 Fedora Update System 2013-08-01 14:24:17 UTC
keybinder3-0.3.0-1.fc18 has been submitted as an update for Fedora 18.

Comment 14 Fedora Update System 2013-08-01 14:24:37 UTC
keybinder3-0.3.0-1.fc19 has been submitted as an update for Fedora 19.

Comment 15 Pierre-Yves Luyten 2013-08-02 11:59:58 UTC
The build are done, closing.

Comment 16 Fedora Update System 2013-08-10 20:00:15 UTC
keybinder3-0.3.0-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 17 Fedora Update System 2013-08-10 20:05:17 UTC
keybinder3-0.3.0-1.fc19 has been pushed to the Fedora 19 stable repository.

Note You need to log in before you can comment on or make changes to this bug.