Bug 871023

Summary: Review Request: glassfish-policy - GlassFish WS-Policy implementation
Product: [Fedora] Fedora Reporter: gil cattaneo <puntogil>
Component: Package ReviewAssignee: Tom "spot" Callaway <tcallawa>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: gang.wei, notting, package-review, tcallawa
Target Milestone: ---Flags: tcallawa: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: glassfish-policy-2.3.1-1.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-26 03:38:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 870977    

Description gil cattaneo 2012-10-29 12:24:25 UTC
Spec URL: http://gil.fedorapeople.org/glassfish-policy.spec
SRPM URL: http://gil.fedorapeople.org/glassfish-policy-2.3.1-1.fc16.src.rpm
Description: The policy project provides the WS-Policy implementation
for Project Metro.
Fedora Account System Username: gil

Comment 2 Tom "spot" Callaway 2013-05-16 18:41:46 UTC
= Review =

Good:

- rpmlint checks return:

glassfish-policy.src: W: invalid-url Source0: policy-2.3.1-src-svn.tar.gz

Safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (CDDL or GPLv2 with exceptions) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (manual diff okay, svn source)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs ok
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED

Comment 3 gil cattaneo 2013-05-16 18:58:24 UTC
Thanks! for the review

New Package SCM Request
=======================
Package Name: glassfish-policy
Short Description: GlassFish WS-Policy implementation
Owners: gil
Branches: f18 f19
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2013-05-16 19:22:55 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-05-16 20:38:26 UTC
glassfish-policy-2.3.1-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/glassfish-policy-2.3.1-1.fc19

Comment 6 Fedora Update System 2013-05-16 20:55:59 UTC
glassfish-policy-2.3.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/glassfish-policy-2.3.1-1.fc18

Comment 7 Fedora Update System 2013-05-17 22:20:15 UTC
glassfish-policy-2.3.1-1.fc19 has been pushed to the Fedora 19 testing repository.

Comment 8 Fedora Update System 2013-05-26 03:38:05 UTC
glassfish-policy-2.3.1-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 9 Fedora Update System 2013-05-27 00:31:05 UTC
glassfish-policy-2.3.1-1.fc18 has been pushed to the Fedora 18 stable repository.