Bug 870977 - Review Request: glassfish-jaxws - JAX-WS Reference Implementation (RI) Project
Summary: Review Request: glassfish-jaxws - JAX-WS Reference Implementation (RI) Project
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 845735 859110 859111 859112 865787 869504 869610 871021 871023
Blocks: 915864
TreeView+ depends on / blocked
 
Reported: 2012-10-29 10:15 UTC by gil cattaneo
Modified: 2013-06-03 19:29 UTC (History)
4 users (show)

Fixed In Version: glassfish-jaxws-2.2.7-1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-03 03:45:13 UTC
Type: ---
Embargoed:
tcallawa: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description gil cattaneo 2012-10-29 10:15:56 UTC 
Spec URL: http://gil.fedorapeople.org/glassfish-jaxws.spec
SRPM URL: http://gil.fedorapeople.org/glassfish-jaxws-2.2.7-1.fc16.src.rpm
Description: 
This project provides the core of Metro project,
inside GlassFish community. This project develops and
evolves the code base for the reference implementation of
the Java API for XML Web Services (JAX-WS) specification.

Fedora Account System Username: gil
Comment 1 Tom "spot" Callaway 2013-05-17 14:26:41 UTC 
You are missing BuildRequires: ant-findbugs

Please regenerate the SRPM and I'll finish this review.
Comment 2 gil cattaneo 2013-05-17 17:52:40 UTC 
Spec URL: http://gil.fedorapeople.org/glassfish-jaxws.spec
SRPM URL: http://gil.fedorapeople.org/glassfish-jaxws-2.2.7-1.fc18.src.rpm

- added missing BR: ant-findbugs
Comment 3 gil cattaneo 2013-05-19 01:10:25 UTC 
Spec URL: http://gil.fedorapeople.org/glassfish-jaxws.spec
SRPM URL: http://gil.fedorapeople.org/glassfish-jaxws-2.2.7-1.fc18.src.rpm

- added missing BR: ant-junit

Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5397468
Comment 4 Tom "spot" Callaway 2013-05-21 15:04:24 UTC 
= Review =

Good:

- rpmlint checks return:
glassfish-jaxws.src: W: invalid-url Source0: glassfish-jaxws-2.2.7-src-svn.tar.xz

Safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license ((CDDL or GPLv2 with exceptions) and ASL 2.0 and Public Domain) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (manual diff okay, due to svn source)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- javadocs okay
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED.
Comment 5 gil cattaneo 2013-05-21 16:14:21 UTC 
Thanks for review

New Package SCM Request
=======================
Package Name: glassfish-jaxws
Short Description: JAX-WS Reference Implementation (RI) Project
Owners: gil
Branches: f18 f19
InitialCC: java-sig
Comment 6 Gwyn Ciesla 2013-05-21 16:25:49 UTC 
Git done (by process-git-requests).
Comment 7 Fedora Update System 2013-05-24 23:58:55 UTC 
glassfish-jaxws-2.2.7-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/glassfish-jaxws-2.2.7-1.fc19
Comment 8 Fedora Update System 2013-05-25 19:05:34 UTC 
glassfish-jaxws-2.2.7-1.fc19 has been pushed to the Fedora 19 testing repository.
Comment 9 Fedora Update System 2013-06-03 03:45:13 UTC 
glassfish-jaxws-2.2.7-1.fc19 has been pushed to the Fedora 19 stable repository.
Note You need to log in before you can comment on or make changes to this bug.