Bug 871083

Summary: Allow connection to the guest with non-responsive agent
Product: Red Hat Enterprise Virtualization Manager Reporter: David Jaša <djasa>
Component: ovirt-engine-userportalAssignee: Arik <ahadas>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.1.0CC: acathrow, dyasny, ecohen, iheim, italkohe, michal.skrivanek, ofrenkel, Rhev-m-bugs, sgrinber, vfeenstr, ykaul
Target Milestone: ---Keywords: ZStream
Target Release: 3.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: virt
Fixed In Version: sf1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 886936 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 886936, 915537    
Attachments:
Description Flags
warning dialog on spice connection to guest with non responsive agent
none
Updated screenshot for the proposed dialog
none
engine log for period when guest agent was not running none

Description David Jaša 2012-10-29 15:11:55 UTC
Description of problem:
Allow connection to the guest with non-responsive agent.

The current behaviour is a workaround for spicec limitation that when agent-related feature was requested from it, it stalled until it established communication with agent. Spice-gtk-based clients are more fault-tolerant in this respect so this hard limitation of User Portal could safely be turned to soft one ("Agent is not responsive. Some features may not work. [cancel] [connect anyway]").


Version-Release number of selected component (if applicable):
si19.1 / 3.1.0-18

How reproducible:
always

Steps to Reproduce:
1. have a Windows VM with tools (mainly virtio-serial, rhev-agent and spice-vdagent running)
2. stop rhev-agent service
3. wait a while
4. try to connect to the VM again
  
Actual results:
you get this message:
Error while executing action VmLogon: Guest agent non-responsive
[close]

Expected results:
you get either dismissable warning (as outlined above; preferable solution) or no warning at all.

Additional info:

Comment 1 Arik 2012-12-10 12:34:54 UTC
Created attachment 660798 [details]
warning dialog on spice connection to guest with non responsive agent

Comment 2 Arik 2012-12-10 13:00:36 UTC
Simon - is the dialog in the attached picture seems ok? (if the user press cancel, the spice console connection is aborted, and if the user press ok the spice console is opened without logon)

Comment 3 Arik 2012-12-11 16:08:43 UTC
Created attachment 661532 [details]
Updated screenshot for the proposed dialog

Comment 4 Simon Grinberg 2012-12-12 17:41:29 UTC
(In reply to comment #2)
> Simon - is the dialog in the attached picture seems ok? (if the user press
> cancel, the spice console connection is aborted, and if the user press ok
> the spice console is opened without logon)

What happens if the tools are not installed in the first place? does the pop-up shows or do we connect anyhow? If it is the same then please change the first line.

Could not connect to the agent on the guest, it may be unresponsive or not installed.  

You can drop the third line, it's clear that the action is proceed or abort. 


We also need the option ignore that message for good, but this is part of the persistent session issues or the VM configuration.

Comment 5 Arik 2012-12-13 15:18:10 UTC
http://gerrit.ovirt.org/#/c/10030/

Comment 15 Jiri Belka 2013-01-28 12:13:11 UTC
Created attachment 688902 [details]
engine log for period when guest agent was not running

Comment 18 Jiri Belka 2013-01-30 09:37:16 UTC
OK, sf4. The popup appears in max time 125 seconds (120 time used by vdsm to trigger agent as non-responding, 5sec is HB time of agent). When agent is down, logging off and in in User Portal the popup is shows immediatelly, so OK.

I will discuss about this 125 seconds, if it could not be done shorter and based on this discussion there could be new BZ for improvement.

Ad 'do not show any more' checkbox, it does not exist now but if it would be implemented please reset this trigger when the VM is started again.

Comment 19 Jiri Belka 2013-01-30 10:09:33 UTC
Proposed BZ905846 for cca 125 secs improvement.

Comment 20 Itamar Heim 2013-06-11 08:39:40 UTC
3.2 has been released

Comment 21 Itamar Heim 2013-06-11 08:39:50 UTC
3.2 has been released

Comment 22 Itamar Heim 2013-06-11 08:39:52 UTC
3.2 has been released

Comment 23 Itamar Heim 2013-06-11 08:47:35 UTC
3.2 has been released