Bug 872791
| Summary: | TypeError: Argument 1 does not allow None as a value | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Tyler <stephent98> | ||||||||||||||||||||||||||||||||||
| Component: | anaconda | Assignee: | Chris Lumens <clumens> | ||||||||||||||||||||||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||||||||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||||||||||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||||||||||||||||||||
| Version: | 18 | CC: | anaconda-maint-list, awilliam, g.kaviyarasu, jonathan, jreznik, piotrdrag, robatino, stephent98, vanmeeuwen+fedora, vpodzime, w_pirker | ||||||||||||||||||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||||||||||||||||
| Hardware: | x86_64 | ||||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||||
| Whiteboard: | abrt_hash:e1beb459df3d56c687be8d29a0adde76ff1347f99ea0ad74af4b302fb5b0bb54 AcceptedBlocker | ||||||||||||||||||||||||||||||||||||
| Fixed In Version: | anaconda-18.25-1 | Doc Type: | Bug Fix | ||||||||||||||||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||||||||||||||||
| Last Closed: | 2012-11-08 09:16:33 UTC | Type: | --- | ||||||||||||||||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||||||||||||||||
| Bug Depends On: | |||||||||||||||||||||||||||||||||||||
| Bug Blocks: | 752660, 858801, 872282 | ||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||
|
Description
Steve Tyler
2012-11-03 07:03:37 UTC
Created attachment 637386 [details]
File: anaconda-tb
Created attachment 637387 [details]
File: environ
Created attachment 637388 [details]
File: type
Created attachment 637389 [details]
File: ifcfg.log
Created attachment 637390 [details]
File: storage.log
Created attachment 637391 [details]
File: version
Created attachment 637392 [details]
File: program.log
Created attachment 637393 [details]
File: product
Created attachment 637394 [details]
File: anaconda.log
Created attachment 637395 [details]
File: hashmarkername
Created attachment 637396 [details]
File: packaging.log
Created attachment 637397 [details]
File: cmdline_file
Created attachment 637398 [details]
File: release
Created attachment 637399 [details]
File: messages
Created attachment 637400 [details]
File: other involved packages
Select 'Chinese (China)' for install language. Package: anaconda-18.24-1.fc18.x86_64 OS Release: Fedora release 18 This was with anaconda-18.24-1 on Fedora-18-Beta-TC6-x86_64-Live-Desktop.iso. I successfully completed at least six previous test installs with other languages. I reproduced the crash a second time. Then I tried installing in English, and that succeeded. Installing with zh_CN also crashed. $ qemu-kvm -m 4096 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC6/Fedora-18-Beta-TC6-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse Choose Dutch for install language. Package: anaconda-18.24-1.fc18.x86_64 OS Release: Fedora release 18 Choose 'Chinese (Taiwan)' for install language. Package: anaconda-18.24-1.fc18.x86_64 OS Release: Fedora release 18 (In reply to comment #19) > Choose 'Chinese (Taiwan)' for install language. > > Package: anaconda-18.24-1.fc18.x86_64 > OS Release: Fedora release 18 This time it was with Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso: $ qemu-kvm -m 4096 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC7/Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse Created attachment 637431 [details]
anaconda-tb-G_2Git from Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso
Crash while installing in Japanese.
$ qemu-kvm -m 4096 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC7/Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse
* select installation destination, click on Continue * click combobox I don't need help * click on a expander * then the unkown error warning dialog pops up as installation medium a USB thumb drive was used. Created with the livecd-iso-to-disk tool. Package: anaconda-18.24-1.fc18.x86_64 OS Release: Fedora release 18 Downgrade to anaconda-18.23-1. Choose Dutch for install language. Package: anaconda-18.23-1.fc18.x86_64 OS Release: Fedora release 18 This bug does not occur in anaconda-18.22-1. Tested with: 1. Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso 2. Dutch, Japanese. So the problem was introduced in anaconda-18.23-1 (Comment 23). $ qemu-kvm -m 4096 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC7/Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse w_pirker: what language did you pick for install? Does the error occur if you pick English? This looks like a blocker. The crash does not occur with these languages: Bosnian Basque Armenian Georgian Bengali (India) NB: This list is not comprehensive ... Adam, I did choose Deutsch (German) as language. I tested it if it happens with English as well. It doesn't happen then. I think this is related to glade translations not always working right. The point where this fails is trying to match a hard-coded translated string to the translated string in the Type combobox. Not finding a match would cause this traceback. Discussed at 2012-11-05 QA meeting acting as a blocker review meeting. Accepted as a blocker per criterion "The installer must boot and run on all primary architectures, with all system firmware types that are common on those architectures, from default live image, DVD, and boot.iso install media when written to an optical disc and when written to a USB stick", in the case of many non-English languages (we've seen several people hit this bug with various languages). Well that was tedious. Posting a patch later today. *** Bug 872795 has been marked as a duplicate of this bug. *** anaconda-18.25-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.25-1.fc18 anaconda-18.24-1 reproducer:
Create a disc image with partitions.
Select one of these install languages:
Chinese (Taiwan)
Dutch
Japanese
Spanish
NB: This bug does not occur with all install languages.
Click Installation Destination.
Click Continue.
Check "I don't need help ...".
Click "Reclaim space".
Click "+" to expand the list of preexisting partitions.
NB: If you don't read the install language, you will need to memorize the locations of the buttons and boxes.
Tested with:
$ qemu-kvm -m 2048 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC7/Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse
This bug does not occur with anaconda-18.25-1 using the reproducer in Comment 34.[1] Tested with: $ qemu-kvm -m 2048 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC7/Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse [1] The reproducer does not provide test complete coverage for the changes in the commit to fix this bug: -rw-r--r-- pyanaconda/ui/gui/spokes/custom.py 94 -rw-r--r-- pyanaconda/ui/gui/spokes/datetime_spoke.py 4 -rw-r--r-- pyanaconda/ui/gui/spokes/keyboard.py 4 -rw-r--r-- pyanaconda/ui/gui/spokes/source.py 14 4 files changed, 58 insertions, 58 deletions Mark strings at the top of spokes with N_; translate later with _ (#872791). http://git.fedorahosted.org/cgit/anaconda.git/commit/?id=0d5138002d0f842cacd90562e9b3a96a20329720 Package anaconda-18.25-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-18.25-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-17691/anaconda-18.25-1.fc18 then log in and leave karma (feedback). anaconda-18.26-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.26-1.fc18 Built a live image with anaconda 18.26 for smoke testing. Tried to install in German. Hit this crash in custom partitioning. I expect it'll be a dupe of 872791 which was supposed to be fixed in 18.26, so fails QA. Package: anaconda-18.26-1.fc18.x86_64 OS Release: Fedora release 18 Please attach the traceback. Package anaconda-18.26-1.fc18, lorax-18.22-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-18.26-1.fc18 lorax-18.22-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-17714/lorax-18.22-1.fc18,anaconda-18.26-1.fc18 then log in and leave karma (feedback). STOP IT BODHI OK, so my test case was actually crazier than I thought (late night error, sorry). It was this: 1. Pick Deutsch (Deutschland) at the pre-hub language select screen 2. Change back to English (U.S.) by clicking on the language option on the hub 3. Go to custom partitioning and try to remove an existing partition Apparently it's 'never going to work' to change the language from the hub, so we should just take that option out. I'll file that separately. If I leave the install in German, I don't hit this traceback, though I do see another bug which I'll also file separately. Setting VERIFIED. Filed https://bugzilla.redhat.com/show_bug.cgi?id=874263 for the reproducer in comment #42. anaconda-18.27-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.27-1.fc18 18.26 went stable. Closing. (Bodhi closing of bugs when updates go stable is currently broken). Subsequent dupes are likely https://bugzilla.redhat.com/show_bug.cgi?id=874263 or some other variation. Adam: The commit[1] to fix this bug appears to have introduced: Bug 873762 - [zh_CN] [zh_TW] installer hangs in Installation Summary when keyboard spoke clicked See: [master] [PATCH] Encode unicode strings from XklWrapper (#873762) https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/002008.html The commit made 58 insertions, 58 deletions in 4 files.[2] I am concerned that this bug is being closed prematurely without fully analyzing the commit or testing all of the changes. [1] Mark strings at the top of spokes with N_; translate later with _ (#872791). http://git.fedorahosted.org/cgit/anaconda.git/commit/?id=0d5138002d0f842cacd90562e9b3a96a20329720 [2] The diffstat from Comment 35: -rw-r--r-- pyanaconda/ui/gui/spokes/custom.py 94 -rw-r--r-- pyanaconda/ui/gui/spokes/datetime_spoke.py 4 -rw-r--r-- pyanaconda/ui/gui/spokes/keyboard.py 4 -rw-r--r-- pyanaconda/ui/gui/spokes/source.py 14 4 files changed, 58 insertions, 58 deletions Here are the posts from anaconda-patches: [PATCH] fixes for f18-beta https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/001927.html (In reply to comment #46) > Adam: The commit[1] to fix this bug appears to have introduced: > > Bug 873762 - [zh_CN] [zh_TW] installer hangs in Installation Summary when > keyboard spoke clicked > > See: > [master] [PATCH] Encode unicode strings from XklWrapper (#873762) > https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/ > 002008.html > > The commit made 58 insertions, 58 deletions in 4 files.[2] I am concerned > that this bug is being closed prematurely without fully analyzing the commit > or testing all of the changes. Yes the fix for this bug introduced bug 873762, but only by hitting the issue that was hidden before by actually using translated strings. (In reply to comment #48) ... > Yes the fix for this bug introduced bug 873762, but only by hitting the > issue that was hidden before by actually using translated strings. Thanks for your comment. I will rephrase my summary: :-) "The commit to fix this bug _exposed_ Bug 873762." Steve: when an update is marked as fixing a bug, the bug is usually automatically closed when the update is pushed stable. That mechanism is currently broken so I just went through and did the same thing manually, but this is what would have happened anyway if Bodhi weren't broken. The anaconda build in question fixed something like 25-30 bugs; it's really not practical for us to go through and thoroughly test every single change before pushing the update stable or closing the bugs. We'd never get done. We _did_ specifically verify and test the blockers, including this one. As Vratislav points out, this fix was correct and did not introduce any regression, it just allowed you to hit a bug that was present all along in any case. There would be no benefit in leaving this bug open, closing it is correct. |