Bug 873762

The hang does not occur with anaconda-18.24-1 on F18-Beta/TC7/Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso.

Tested with:
$ qemu-kvm -m 2048 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC7/Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse

How are you testing anaconda-18.25-1? I cannot reproduce this using our image with updates.img. Of course there is a common (not related to chosen language) short hang when the Installation Summary appears.

I'm booting Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso in a VM[1], installing koji, downloading anaconda with koji[2], and updating anaconda with yum:

Sometimes I get:
Bug 873767 - UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 3: ordinal not in range(128)

[1] Command-line:
$ qemu-kvm -m 2048 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC7/Fedora-18-Beta-TC7-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse

[2] anaconda builds on koji:
Information for build anaconda-18.25-1.fc18
ID	364607
http://koji.fedoraproject.org/koji/buildinfo?buildID=364607

Information for build anaconda-18.26-1.fc18
ID	364893
http://koji.fedoraproject.org/koji/buildinfo?buildID=364893

The hang appears to be a long stall that ends with "An unknown error has occurred" and a UnicodeDecodeError exception.

In one test with anaconda-18.25-1.fc18, there was a 2 min, 33 sec delay after clicking the keyboard spoke until the UnicodeDecodeError exception occurred:

Bug 873767, Comment 16

A duplicate?

(In reply to comment #4)
> The hang appears to be a long stall that ends with "An unknown error has
> occurred" and a UnicodeDecodeError exception.
> 
> In one test with anaconda-18.25-1.fc18, there was a 2 min, 33 sec delay
> after clicking the keyboard spoke until the UnicodeDecodeError exception
> occurred:
> 
> Bug 873767, Comment 16
> 
> A duplicate?
Probably. It is definitely related. I'll try to reproduce this myself because it needs some debugging. If I cannot reproduce it, I'll send you some instuctions for debugging.

Fix posted to anaconda-patches list.

*** Bug 873767 has been marked as a duplicate of this bug. ***

[master] [PATCH] Encode unicode strings from XklWrapper (#873762)
https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/002008.html

Thanks. That was subtle. This bug may have been introduced with the commit[1] to fix:

Bug 872791 - TypeError: Argument 1 does not allow None as a value

Could you take a look at Bug 872791, Comment 46 concerning that hypothesis?

[1] Mark strings at the top of spokes with N_; translate later with _ (#872791).
http://git.fedorahosted.org/cgit/anaconda.git/commit/?id=0d5138002d0f842cacd90562e9b3a96a20329720

(In reply to comment #8)
> [master] [PATCH] Encode unicode strings from XklWrapper (#873762)
> https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/
> 002008.html
> 
> Thanks. That was subtle. This bug may have been introduced with the
> commit[1] to fix:
...

Isn't there a way to do this more generally, so developers don't have to keep track of when foo.encode() is needed and when it is not needed?

-            self._layoutSwitchLabel.set_text(_(LAYOUT_SWITCHING_INFO) % desc)
+            self._layoutSwitchLabel.set_text(_(LAYOUT_SWITCHING_INFO) % \
+                                                 desc.encode("utf-8"))

Maybe it is not such a widespread problem:

$ egrep -rc 'encode|decode' anaconda-18.27-1/pyanaconda/ | sort | grep -v ':0$'
anaconda-18.27-1/pyanaconda/__init__.py:1
anaconda-18.27-1/pyanaconda/iutil.py:1
anaconda-18.27-1/pyanaconda/keyboard.py:3
anaconda-18.27-1/pyanaconda/localization.py:1

(In reply to comment #8)
> [master] [PATCH] Encode unicode strings from XklWrapper (#873762)
> https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/
> 002008.html
> 
> Thanks. That was subtle. This bug may have been introduced with the
> commit[1] to fix:
> 
> Bug 872791 - TypeError: Argument 1 does not allow None as a value
> 
> Could you take a look at Bug 872791, Comment 46 concerning that hypothesis?
> 
> [1] Mark strings at the top of spokes with N_; translate later with _
> (#872791).
> http://git.fedorahosted.org/cgit/anaconda.git/commit/
> ?id=0d5138002d0f842cacd90562e9b3a96a20329720
Done.

(In reply to comment #9)
> (In reply to comment #8)
> > [master] [PATCH] Encode unicode strings from XklWrapper (#873762)
> > https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/
> > 002008.html
> > 
> > Thanks. That was subtle. This bug may have been introduced with the
> > commit[1] to fix:
> ...
> 
> Isn't there a way to do this more generally, so developers don't have to
> keep track of when foo.encode() is needed and when it is not needed?
> 
> -            self._layoutSwitchLabel.set_text(_(LAYOUT_SWITCHING_INFO) %
> desc)
> +            self._layoutSwitchLabel.set_text(_(LAYOUT_SWITCHING_INFO) % \
> +                                                 desc.encode("utf-8"))
Yeah, I was thinking about it a bit further and I've just posted a new patch to anaconda-patches. Thanks!

[PATCHv2] Encode unicode strings from XklWrapper (#873762)
https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/002028.html

Thanks. It looks like that could have some side-effects:

$ grep -rc switch_to_show_str anaconda-18.27-1/pyanaconda/ | grep -v ':0$'
anaconda-18.27-1/pyanaconda/keyboard.py:2
anaconda-18.27-1/pyanaconda/ui/gui/spokes/keyboard.py:4

(In reply to comment #13)
> [PATCHv2] Encode unicode strings from XklWrapper (#873762)
> https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/
> 002028.html
> 
> Thanks. It looks like that could have some side-effects:
> 
> $ grep -rc switch_to_show_str anaconda-18.27-1/pyanaconda/ | grep -v ':0$'
> anaconda-18.27-1/pyanaconda/keyboard.py:2
These are two lines where switch_to_show_str gets populated.

> anaconda-18.27-1/pyanaconda/ui/gui/spokes/keyboard.py:4
These are lines really using the dict and I believe I've tested all these places to work with the new patch.

(In reply to comment #14)
> (In reply to comment #13)
> > [PATCHv2] Encode unicode strings from XklWrapper (#873762)
> > https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/
> > 002028.html
> > 
> > Thanks. It looks like that could have some side-effects:
> > 
> > $ grep -rc switch_to_show_str anaconda-18.27-1/pyanaconda/ | grep -v ':0$'
> > anaconda-18.27-1/pyanaconda/keyboard.py:2
> These are two lines where switch_to_show_str gets populated.
> 
> > anaconda-18.27-1/pyanaconda/ui/gui/spokes/keyboard.py:4
> These are lines really using the dict and I believe I've tested all these
> places to work with the new patch.

Thanks for checking those.

Proposing as an F18 Beta Blocker:

1. Cannot be fixed with an update.

2. Per the rationale in Bug 872791, Comment 30, which implicitly amends Alpha Release Criterion 5 to apply "in the case of many non-English languages":
https://fedoraproject.org/wiki/Fedora_18_Alpha_Release_Criteria

The bug can be reproduced with zh_CN and zh_TW, both of which show 97% translation coverage in Master for anaconda at Transifex[1].

Criterion 5 could be quantitatively amended to apply to languages for which the installer translation coverage is above a certain percentage or above the median translation coverage.

[1] The translation coverage was 100% in Master until new strings were added:
https://fedora.transifex.com/projects/p/anaconda/resource/master/

Discussed at 2012-11-12 QA meeting acting as a blocker review meeting. Accepted as a blocker per criterion  "The installer must be able to complete an installation using the text, graphical and VNC installation interfaces".

anaconda-18.29-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/anaconda-18.29-1.fc18

Package anaconda-18.29-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-18.29-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-18105/anaconda-18.29-1.fc18
then log in and leave karma (feedback).

I can no longer reproduce the problem with Beta TC9 (anaconda 18.29), neither on Live nor on netinst, marking as VERIFIED. Steve, please try it as well, thanks.

Verifying that the keyboard spoke is displayed as expected with F18-Beta-TC9 (with anaconda 18.29). Tested with Live and DVD:

$ qemu-kvm -m 2048 -hda f18-test-1.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC9/Fedora-18-Beta-TC9-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse

$ qemu-kvm -m 2048 -hda f18-test-1.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC9/Fedora-18-Beta-TC9-x86_64-DVD.iso -usb -vga qxl -boot menu=on -usbdevice mouse

18.29.2-1 is currently being pushed stable, closing.

anaconda-18.29-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.