Bug 875313 (python-corba)

Summary: Review Request: python-corba - MATE Desktop python corba bindings
Product: [Fedora] Fedora Reporter: Dan Mashal <dan.mashal>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED CANTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: leigh123linux, notting, package-review, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-18 09:20:25 EST Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On: 840149    
Bug Blocks: 875308    

Description Dan Mashal 2012-11-10 07:15:53 EST
SPEC URL: http://vicodan.fedorapeople.org/matespec/python-corba.spec

SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/python-corba-1.4.0-1.fc19.src.rpm

Description: MATE Desktop python corba bindings
Comment 1 Dan Mashal 2012-11-10 07:40:50 EST
*** Bug 875315 has been marked as a duplicate of this bug. ***
Comment 2 leigh scott 2012-11-10 08:31:39 EST
Your buildrequires are wrong

change

BuildRequires:	mate-common mate-doc-utils mate-corba-devel gtk2-devel python2-devel pygobject2-devel pygtk2-devel 


to

BuildRequires: mate-corba-devel
BuildRequires: glib2-devel
BuildRequires: libIDL-devel
BuildRequires: mate-common
BuildRequires: python2-devel



You need to filter the provides

add

# We don't want to provide private python extension libs.
%{?filter_setup:
%filter_provides_in %{python_sitearch}/.*\.so$
%filter_setup
}



package description is wrong please fix


%description
MATE Desktop menu editor


In fact they are all off IMO


%description
MATE Desktop menu editor

%package devel
Summary: MATE Desktop python corba bindings

%description devel
MATE Desktop python corba bindings


This would be better and adds the missing requirement on devel



%description
Provides the Python bindings for mate-corba

%package devel
Summary: Development files for python-corba
Requires: %{name}%{?_isa} = %{version}-%{release}

%description devel
Provides the development files for the Python bindings
used by mate-corba
Comment 3 leigh scott 2012-11-18 09:20:25 EST
This package is retired upstream.