Bug 877303

Summary: virsh snapshot-edit prints garbage with wrong parameters
Product: Red Hat Enterprise Linux 6 Reporter: Ján Tomko <jtomko>
Component: libvirtAssignee: Ján Tomko <jtomko>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.4CC: acathrow, dallan, dyasny, dyuan, mjenner, mzhan, rwu, whuang, zhpeng
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-0.10.2-9.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-21 07:26:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 881827    

Description Ján Tomko 2012-11-16 08:25:43 UTC
Description of problem:

virsh snapshot-edit <nonexistent domain> <snapshot>
virsh snapshot-edit <domain> <nonexistent snapshot>

both output an error message (besides other):
error: Failed to update HE

Version-Release number of selected component (if applicable):
libvirt-0.10.2-8.el6

How reproducible:
100 %

Steps to Reproduce:
virsh snapshot-edit asdnkl akldsakm
  
Actual results:
error: failed to get domain 'asdnkl'
error: Failed to update HE
error: Domain not found: no domain with matching name 'asdnkl'

Expected results:
without "error: Failed to update HE"

Additional info:
Already fixed upstream by:
commit 689b64d666bc268d55395a92a2b9d6cd51b3ad70
Author:     Ján Tomko <jtomko>
AuthorDate: Thu Nov 15 11:37:32 2012
Commit:     Michal Privoznik <mprivozn>
CommitDate: Thu Nov 15 11:45:40 2012

    virsh: fix uninitialized variable in cmdSnapshotEdit

Comment 4 zhpeng 2012-11-21 01:50:18 UTC
# virsh snapshot-edit asdf sadf
error: failed to get domain 'asdf'
error: Domain not found: no domain with matching name 'asdf'


# virsh snapshot-edit aaa sdf
error: Domain snapshot not found: no domain snapshot with matching name 'sdf'

So it's verified.

pkg: libvirt-0.10.2-9.el6.x86_64

Comment 5 errata-xmlrpc 2013-02-21 07:26:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html