Bug 877303 – virsh snapshot-edit prints garbage with wrong parameters

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 877303 - virsh snapshot-edit prints garbage with wrong parameters

Summary:	virsh snapshot-edit prints garbage with wrong parameters

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	libvirt (Show other bugs)
Sub Component:
Version:	6.4
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	rc
Target Release:	---
Assigned To:	Ján Tomko
QA Contact:	Virtualization Bugs
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:	881827
	Show dependency tree / graph

Reported:	2012-11-16 03:25 EST by Ján Tomko
Modified:	2013-02-21 02:26 EST (History)
CC List:	9 users (show)

See Also:
Fixed In Version:	libvirt-0.10.2-9.el6
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2013-02-21 02:26:57 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2013:0276	normal	SHIPPED_LIVE	Moderate: libvirt security, bug fix, and enhancement update	2013-02-20 16:18:26 EST

Groups: None (edit)

Description Ján Tomko 2012-11-16 03:25:43 EST

Description of problem:

virsh snapshot-edit <nonexistent domain> <snapshot>
virsh snapshot-edit <domain> <nonexistent snapshot>

both output an error message (besides other):
error: Failed to update HE

Version-Release number of selected component (if applicable):
libvirt-0.10.2-8.el6

How reproducible:
100 %

Steps to Reproduce:
virsh snapshot-edit asdnkl akldsakm
  
Actual results:
error: failed to get domain 'asdnkl'
error: Failed to update HE
error: Domain not found: no domain with matching name 'asdnkl'

Expected results:
without "error: Failed to update HE"

Additional info:
Already fixed upstream by:
commit 689b64d666bc268d55395a92a2b9d6cd51b3ad70
Author:     Ján Tomko <jtomko@redhat.com>
AuthorDate: Thu Nov 15 11:37:32 2012
Commit:     Michal Privoznik <mprivozn@redhat.com>
CommitDate: Thu Nov 15 11:45:40 2012

    virsh: fix uninitialized variable in cmdSnapshotEdit

Comment 2 Ján Tomko 2012-11-16 10:21:38 EST

Moving to POST:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2012-November/msg00168.html

Comment 4 zhpeng 2012-11-20 20:50:18 EST

# virsh snapshot-edit asdf sadf
error: failed to get domain 'asdf'
error: Domain not found: no domain with matching name 'asdf'


# virsh snapshot-edit aaa sdf
error: Domain snapshot not found: no domain snapshot with matching name 'sdf'

So it's verified.

pkg: libvirt-0.10.2-9.el6.x86_64

Comment 5 errata-xmlrpc 2013-02-21 02:26:57 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html

Note You need to log in before you can comment on or make changes to this bug.