Bug 877985

Summary:	Review Request: pss - A power-tool for searching inside source code files
Product:	[Fedora] Fedora	Reporter:	kushaldas@gmail.com <mail>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ffotorel, notting, package-review, panemade, volker27
Target Milestone:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-04-16 05:10:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description kushaldas@gmail.com 2012-11-19 11:18:04 UTC

Spec URL: http://kushal.fedorapeople.org/packages/pss.spec
SRPM URL: http://kushal.fedorapeople.org/packages/pss-0.35-1.fc17.src.rpm
Description: pss is a power-tool for searching inside source code files. 
pss searches recursively within a directory tree, knows which 
extensions and file names to search and which to ignore, automatically 
skips directories you wouldn't want to search in (for example .svn or .git),
colors its output in a helpful way, and does much more.

Fedora Account System Username: kushal

This is for both epel and Fedora. Koji scratch builds are in
http://koji.fedoraproject.org/koji/taskinfo?taskID=4703275
http://koji.fedoraproject.org/koji/taskinfo?taskID=4703239

Comment 1 Parag AN(पराग) 2012-11-20 15:40:29 UTC

Issues:
=======
[!]: Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
[!]: Package consistently uses macro is (instead of hard-coded directory
     names).
     Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

Comment 2 kushaldas@gmail.com 2012-12-14 07:00:24 UTC

Updated spec and srpm

Spec URL: http://kushal.fedorapeople.org/packages/pss.spec
SRPM URL: http://kushal.fedorapeople.org/packages/pss-0.35-2.fc17.src.rpm

Comment 3 Volker Fröhlich 2012-12-16 11:59:50 UTC

If you're not out for EPEL (5), remove defattr, clean section, the first rm in the install section and the buildroot definition.

Defining python_sitelib falls in the same category: http://fedoraproject.org/wiki/Packaging:Python#Macros

The first changelog entry is a duplicate, by the way.

You could include CHANGES as documentation.

The website says, it also works with Python 3. Please consider to provide a Python 3 version as well.

Comment 4 kushaldas@gmail.com 2012-12-19 07:44:51 UTC

After more cleanup as suggested:


Spec URL: http://kushal.fedorapeople.org/packages/pss.spec
SRPM URL: http://kushal.fedorapeople.org/packages/pss-0.35-3.fc17.src.rpm

EPEL6 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802140
RAWHIDE build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802142

Comment 5 Parag AN(पराग) 2012-12-21 09:52:35 UTC

Looks good now.

AFAICS in the python guidelines page, its not mandated to provide python3 version as well so I will not block this review.

APPROVED.

Comment 6 kushaldas@gmail.com 2013-02-21 10:15:28 UTC

New Package SCM Request
=======================
Package Name: pss
Short Description: A power-tool for searching inside source code file
Owners: kushal
Branches: el6 f18 f17
InitialCC: kushal

Comment 7 Gwyn Ciesla 2013-02-21 13:24:45 UTC

Git done (by process-git-requests).

Comment 8 Parag AN(पराग) 2013-03-04 04:21:06 UTC

any updates here?

Comment 9 Parag AN(पराग) 2013-04-15 05:13:19 UTC

ping

Comment 10 kushaldas@gmail.com 2013-04-16 05:10:29 UTC

Closing the bug as the build was done successfully.