Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://kushal.fedorapeople.org/packages/pss.spec SRPM URL: http://kushal.fedorapeople.org/packages/pss-0.35-1.fc17.src.rpm Description: pss is a power-tool for searching inside source code files. pss searches recursively within a directory tree, knows which extensions and file names to search and which to ignore, automatically skips directories you wouldn't want to search in (for example .svn or .git), colors its output in a helpful way, and does much more. Fedora Account System Username: kushal This is for both epel and Fedora. Koji scratch builds are in http://koji.fedoraproject.org/koji/taskinfo?taskID=4703275 http://koji.fedoraproject.org/koji/taskinfo?taskID=4703239
Issues: ======= [!]: Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires [!]: Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
Updated spec and srpm Spec URL: http://kushal.fedorapeople.org/packages/pss.spec SRPM URL: http://kushal.fedorapeople.org/packages/pss-0.35-2.fc17.src.rpm
If you're not out for EPEL (5), remove defattr, clean section, the first rm in the install section and the buildroot definition. Defining python_sitelib falls in the same category: http://fedoraproject.org/wiki/Packaging:Python#Macros The first changelog entry is a duplicate, by the way. You could include CHANGES as documentation. The website says, it also works with Python 3. Please consider to provide a Python 3 version as well.
After more cleanup as suggested: Spec URL: http://kushal.fedorapeople.org/packages/pss.spec SRPM URL: http://kushal.fedorapeople.org/packages/pss-0.35-3.fc17.src.rpm EPEL6 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802140 RAWHIDE build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802142
Looks good now. AFAICS in the python guidelines page, its not mandated to provide python3 version as well so I will not block this review. APPROVED.
New Package SCM Request ======================= Package Name: pss Short Description: A power-tool for searching inside source code file Owners: kushal Branches: el6 f18 f17 InitialCC: kushal
Git done (by process-git-requests).
any updates here?
ping
Closing the bug as the build was done successfully.